[Joy] Make variants for more flexible #32931
Merged
+337
−331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
The global variants generated like this for hover, active and disabled:
It makes customization confusing because
softHover
in this case can contain other style that's not speficific to hover and so on. Also the disabled state is fixed to.Mui-disabled
which would be hard for the custom component to use.After
The generation is flat without the states (the key is already explicit)
It is more flexible and easier to understand. Here is one example of bootstrap outlined button using Joy variants: