Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TabsUnstyled] Define ownerState and slot props' types #32918

Merged
merged 1 commit into from
May 27, 2022
Merged

[TabsUnstyled] Define ownerState and slot props' types #32918

merged 1 commit into from
May 27, 2022
+50 −26

Conversation

michaldudak
Copy link
Member

  • Defined types for TabUnstyled's ownerState and its slots.
  • Renamed types and files according to [RFC] Code organization in @mui/base #31415
  • Removed getRootProps from the useTabs return value as it returned an empty object.

@michaldudak michaldudak added component: tabs This is the name of the generic UI component, not the React module! typescript package: base-ui Specific to @mui/base labels May 26, 2022
@michaldudak michaldudak requested a review from mnajdova May 26, 2022 13:12
@mui-bot
Copy link

mui-bot commented May 26, 2022 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against f49c6d0

@michaldudak michaldudak merged commit b1ef896 into mui:master May 27, 2022
@michaldudak michaldudak deleted the ownerstate-types/tabs branch May 27, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova

Assignees
No one assigned
Labels
component: tabs This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaldudak @mui-bot @mnajdova