Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Iterate on the job ad for React engineer in Core #32900

Merged
merged 7 commits into from
May 31, 2022

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented May 25, 2022

Added a11y as a nice to have skill. Mostly opening so that we can iterate if someone has an idea for improving it.

Preview - https://deploy-preview-32900--material-ui.netlify.app/careers/react-engineer-core/

@mui-bot
Copy link

mui-bot commented May 25, 2022

No bundle size changes

Generated by 🚫 dangerJS against 1d4ace0

Copy link
Contributor

@mapache-salvaje mapache-salvaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor copy edits throughout. 👍

@mnajdova mnajdova added the website Pages that are not documentation-related, marketing-focused. label May 26, 2022
mnajdova and others added 5 commits May 27, 2022 11:19
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
@mnajdova
Copy link
Member Author

mnajdova commented May 27, 2022

Thanks for the review on the copywriting @samuelsycamore! After everyone will review this, I will update the template and the other pages too to contain these changes too.

@mnajdova mnajdova marked this pull request as ready for review May 27, 2022 13:22
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks nice.

@mnajdova mnajdova merged commit 27f6cd2 into mui:master May 31, 2022
@oliviertassinari oliviertassinari changed the title [docs] Iterate on the job ad for React engineer in Core [website] Iterate on the job ad for React engineer in Core May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants