[core] Improve the incomplete issues workflow #32878
Conversation
|
Niiice, sounds like MUI X would need too |
Will do it on that repo too after it is merged here :) |
.github/workflows/no-response.yml
Outdated
| # Number of days of inactivity before an Issue is closed for lack of response | ||
| daysUntilClose: 7 | ||
| # Label requiring a response | ||
| responseRequiredLabel: needs more information |
There was a problem hiding this comment.
Should it be "needs more information" or "status: needs more information"? I am ok with both options. cc @DanailH for X
There was a problem hiding this comment.
our current label reads status: needs more information. It would be great if we can keep the status:prefix because we have other statuses but I'm ok to remove it. We should then update the other ones that have status:.
Another argument to keep the prefix is that is more easily searchable when you look for what status to add 🤔
There was a problem hiding this comment.
I agree with the arguments, adding "status:" as a prefix helps for adding it + removing the other status labels :) Let me update.
There was a problem hiding this comment.
Done and tested in dimovi91#4
The other scenario is worse, basically when people are providing a reproduction, but we miss the notification and the issue stays closed. We've seen lots of these in the past weeks. I think it is better if we need to close the issue again, rather than miss the opportunity to fix an issue that has a reproduction |
Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
|
Would this apply only to issues tagged as |
Yes, it is specified here - https://github.com/mui/material-ui/pull/32878/files#diff-f88246a3dee8080e206a12626ee68a976bfd86a1e790c525a43a59e03661f2a0R22 (we will rename the "status: incomplete" with "status: needs more information") Note, we added the "status: " prefix (I will update the PR description) |
|
Do you know if it would be possible to use the new closing reason and mark the issues that need more info or are duplicates as "not planned"? |
I don't see that option on the action we use right now. We can fork the action and see if we can update it, or relay on the labels as anyway older issues won't have this closing status. |
|
OK, let's reconsider this when the action has this option. It's probably not worth spending time on it now. |
|
Alright, I am merging this and renaming the label. |
I've replaced the workflow for closing incomplete issues with a new one, which has all the requirements we have for this specific use-case (closing the issue if inactive & reopening the issue if a comment has been provided). The new workflow is recommended by probot/no-response which is the workflow most often use for this use-case, for example emotion-js.
I've tested the scenarios we want to cover in https://github.com/dimovi91/material-ui/issues