[core] Avoid leaking @babel/runtime #32874
Merged
+2
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,7 +81,7 @@ export default function SandboxDependencies( | |||
| newDeps['@mui/material'] = versions['@mui/material']; | |||
| } | |||
|
|
|||
| // TODO: Where is this coming from and why does it need to be injected this way. | |||
| // TODO: consider if this configuration could be injected in a "cleaner" way. | |||
There was a problem hiding this comment.
Where is this coming from
https://github.com/mui/mui-x/blob/e710d53a7447ac709c51c4edfec07f2549cf8daf/docs/pages/_app.js#L41
siriwatknp
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that we don't need this dependency. https://deploy-preview-32874--material-ui.netlify.app/material-ui/react-checkbox/
As a side note, the version of
@babel/runtimemust be compatible with the version of@babel/plugin-transform-runtimeused. Leaving "latest" might create bugsThis is a quick follow-up on #32726 (happy that we now better support Joy & Base :)