-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix navigation links #32851
[docs] Fix navigation links #32851
Conversation
65deed9
to
e66a355
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, great catches!
@@ -37,7 +37,7 @@ The following chart illustrates how MUI's packages are related to one another: | |||
<img src="/static/images/packages/mui-packages.png" style="width: 796px; margin-top: 4px; margin-bottom: 8px;" alt="The first half of the image shows @mui/material and @mui/base as component libraries, and @mui/system and styled engines as styling solutions, both under the MUI Core umbrella. The second half shows @mui/x-data-grid and @mui/x-date-pickers as components from MUI X."/> | |||
|
|||
In this article, we'll only cover the MUI Core packages. | |||
Check the [MUI X overview](/x/getting-started/overview) for more information about our collection of advanced components. | |||
Check the [MUI X overview](/x/advanced-components/) for more information about our collection of advanced components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the [MUI X overview](/x/advanced-components/) for more information about our collection of advanced components. | |
Check the [MUI X overview](/x/overview/) for more information about our collection of advanced components. |
Should we change the URL for this page? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, it's a 404 (proof https://mui.com/x/overview/) but agrees I believe @samuelsycamore works on this in mui/mui-x#4692, to consider the change if/when merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that we could really benefit from an automated check for broken links! Aside from just typos, future docs revisions will continue to break older links, and they can be difficult to keep track of.
Fix a couple of recent docs navigation regressions. https://app.ahrefs.com/site-audit/3524616/13/issues
We might want to look into implementing checks in the CI so we can have a faster feedback loop. I feel that I need to make this kind of fixes too frequently.