Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Joy] Add AspectRatio demos #32848

Merged
merged 5 commits into from
May 24, 2022
Merged

[Joy] Add AspectRatio demos #32848

merged 5 commits into from
May 24, 2022
+462 −69

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented May 21, 2022 •
edited
Loading

Sorry, something went wrong.

@siriwatknp
add AspectRatio demos

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
8906051
@siriwatknp siriwatknp added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy labels May 21, 2022
@mui-bot
Copy link

mui-bot commented May 21, 2022 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against fd98016

@siriwatknp siriwatknp marked this pull request as ready for review May 22, 2022 10:32
@siriwatknp siriwatknp requested a review from danilo-leal May 23, 2022 05:33
danilo-leal
danilo-leal approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Pushed some small changes but otherwise, it's great!

@siriwatknp siriwatknp merged commit 708b3d0 into mui:master May 24, 2022
dextel2
dextel2 reviewed May 24, 2022
View reviewed changes
Copy link

@dextel2 dextel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dextel2 dextel2

@danilo-leal danilo-leal

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@siriwatknp @mui-bot @dextel2 @danilo-leal