-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Joy] Add Chip
doc
#32819
[Joy] Add Chip
doc
#32819
Conversation
Something I just realized while playing with the demo there is that the size variant is purely affecting the Chip's padding?! I'd intuitively expect that prop to also affect text size, otherwise, we have mostly a difference on horizontal padding. Does that make sense to you @hbjORbj and @siriwatknp? |
I think you don't see the text size changes because there is a Typography (by default it uses |
Right, cool! Just pushed a commit with those changes :) |
Another thing that just came up while designing the email UI: I remember we removed the |
The demos have been done in https://deploy-preview-32819--material-ui.netlify.app/experiments/joy/chip/ |
Looks much better! Some improvements that I think: Basic Decorators
** Delete button**
Clickable
Clickable and Deletable (new)
With checkbox
With radio
|
Thanks for the feedback, Jun. I addressed them all. |
); | ||
})} | ||
</RadioGroup> | ||
</Box> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a TextField
for customizing the children?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice!
Preview: https://deploy-preview-32819--material-ui.netlify.app/joy-ui/react-chip/