Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BadgeUnstyled] Define ownerState and slot props' types #32750

Merged
merged 4 commits into from
May 24, 2022

Conversation

michaldudak
Copy link
Member

Defined types for BadgeUnstyled's ownerState and its slots return type.
Also renamed types and files according to #31415.
Converted source to TS during the process, as it was pretty simple. This way, we ensure the defined types match the implementation.

@michaldudak michaldudak added component: badge This is the name of the generic UI component, not the React module! typescript package: base-ui Specific to @mui/base labels May 12, 2022
@michaldudak michaldudak requested a review from mnajdova May 12, 2022 11:22
@mui-bot
Copy link

mui-bot commented May 12, 2022

Details of bundle changes

Generated by 🚫 dangerJS against 3dd57b7

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 12, 2022
@michaldudak michaldudak force-pushed the ownerstate-types/badge branch from bdeab04 to 3dd57b7 Compare May 13, 2022 11:27
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 13, 2022
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@michaldudak michaldudak merged commit f1994bf into mui:master May 24, 2022
@michaldudak michaldudak deleted the ownerstate-types/badge branch May 24, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: badge This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants