[SliderUnstyled] Define ownerState and slot props' types #32739
Merged
+265
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
component: slider
mnajdova
reviewed
May 24, 2022
| @@ -237,9 +237,6 @@ const SliderUnstyled = React.forwardRef(function SliderUnstyled(props, ref) { | |||
| [classes.active]: active === index, | |||
| [classes.focusVisible]: focusVisible === index, | |||
| })} | |||
| {...(!isHostComponent(Thumb) && { | |||
| ownerState: SliderUnstyledOwnerState; | ||
| }; | ||
|
|
||
| export type SliderUnstyledTrackSlotProps = UseSliderRootSlotProps & { |
There was a problem hiding this comment.
The UseSliderRootSlotProps also contains the ref no? Would that be a problem? Also, why would we have here this and not in the rest of the slots, for example SliderUnstyledRailSlotProps?
There was a problem hiding this comment.
Too much copy-pasta. SliderUnstyledTrackSlotProps does not extend UseSliderRootSlotProps. The SliderUnstyled implementation is still JS, so TS did not catch the error.
mnajdova
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defined types for SliderUnstyled's
ownerState, its slots and useSlider return type.Also renamed types and files according to #31415