[SwitchUnstyled] Define ownerState and slot props' types #32573
Conversation
michaldudak
added
component: switch
github-actions
bot
added
the
PR: out-of-date
michaldudak
force-pushed
the
ownerstate-types/switch
branch
from
818ec67 to
e31af1c
Compare
github-actions
bot
removed
the
PR: out-of-date
michaldudak
changed the title
packages/mui-joy/src/Radio/Radio.tsx
Outdated
| PropTypes.oneOf(['danger', 'info', 'primary', 'success', 'warning']), | ||
| PropTypes.string, | ||
| ]), | ||
| color: PropTypes.oneOf(['danger', 'info', 'neutral', 'primary', 'success', 'warning']), |
There was a problem hiding this comment.
Yes, thanks!
BTW, the generated proptypes include neutral, which does not exist in the hardcoded ones (it's a similar case in `variant'). Shouldn't the hardcoded ones be updated? (cc @siriwatknp)
There was a problem hiding this comment.
Nice catch, I guess it should be added indeed. @siriwatknp in case if you missed the prev notification :)
| PropTypes.oneOf(['danger', 'info', 'primary', 'success', 'warning']), | ||
| PropTypes.string, | ||
| ]), | ||
| color: PropTypes.oneOf(['danger', 'info', 'neutral', 'primary', 'success', 'warning']), |
| onFocus: (event: React.FocusEvent) => handleFocus(event, otherProps.onFocus), | ||
| onBlur: (event: React.FocusEvent) => handleBlur(event, otherProps.onBlur), | ||
| ref: handleRefChange, | ||
| onChange: createHandleInputChange(otherProps), |
| required?: boolean; | ||
| } | ||
|
|
||
| interface UseSwitchInputSlotOwnProps { |
There was a problem hiding this comment.
Should we extend here UseSwitchParameters?
There was a problem hiding this comment.
The optionality of parameters differs. Plus, the UseSwitchParameters has onFocusVisible, which is not a valid HTML parameter. I could Pick, Omit, etc. but it would be less readable than specifying the interface explicitly IMO.
|
|
||
| describe('useSwitch', () => { | ||
| const { render } = createRenderer(); | ||
| const invokeUseSwitch = (props: UseSwitchProps): UseSwitchResult => { | ||
| const ref = React.createRef<UseSwitchResult>(); | ||
| const invokeUseSwitch = (props: UseSwitchParameters) => { |
There was a problem hiding this comment.
Let's mark this as breaking change so that we can add it in the changelog for people to be aware of.
Defined types for SwitchUnstyled's ownerState, its slots and useSwitch return type.
Also renamed types and files according to #31415