Skip to content

Commit 5e70b9f

Browse files
committedOct 13, 2019
feat: update eslint to v6
- Update react component method order - Update eslint-plugin-jsdoc version - Update eslint-plugin-react-hooks version - Update dev deps BREAKING CHANGE: eslint v6 is now required
1 parent 97734e6 commit 5e70b9f

File tree

5 files changed

+2595
-2037
lines changed

5 files changed

+2595
-2037
lines changed
 

‎package-lock.json

+2,560-2,015
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

+13-13
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@
3131
},
3232
"husky": {
3333
"hooks": {
34-
"commit-msg": "commitlint -E HUSKY_GIT_PARAMS",
35-
"pre-commit": "lint-staged"
34+
"pre-commit": "lint-staged",
35+
"commit-msg": "commitlint -E HUSKY_GIT_PARAMS"
3636
}
3737
},
3838
"lint-staged": {
@@ -47,30 +47,30 @@
4747
]
4848
},
4949
"peerDependencies": {
50-
"eslint": "^5.7.0"
50+
"eslint": "^6.0.0"
5151
},
5252
"dependencies": {
53-
"babel-eslint": "^11.0.0-beta.0",
53+
"babel-eslint": "^10.0.3",
5454
"eslint-plugin-babel": "^5.3.0",
5555
"eslint-plugin-jest": "^22.3.0",
56-
"eslint-plugin-jsdoc": "^4.1.0",
56+
"eslint-plugin-jsdoc": "^15.11.0",
5757
"eslint-plugin-prefer-import": "0.0.1",
58-
"eslint-plugin-react": "^7.10.0",
59-
"eslint-plugin-react-hooks": "^1.7.0"
58+
"eslint-plugin-react": "^7.16.0",
59+
"eslint-plugin-react-hooks": "^2.1.2"
6060
},
6161
"devDependencies": {
6262
"@babel/core": "^7.3.3",
63-
"@commitlint/cli": "^7.0.0",
64-
"@commitlint/config-conventional": "^7.0.1",
63+
"@commitlint/cli": "^8.2.0",
64+
"@commitlint/config-conventional": "^8.2.0",
6565
"babel-preset-moxy": "^3.0.4",
6666
"create-react-class": "^15.6.3",
67-
"eslint": "^5.3.0",
68-
"husky": "^1.3.1",
67+
"eslint": "^6.5.1",
68+
"husky": "^3.0.9",
6969
"jest": "^24.5.0",
70-
"lint-staged": "^8.1.4",
70+
"lint-staged": "^9.4.2",
7171
"prop-types": "^15.6.2",
7272
"react": "^16.8.3",
73-
"standard-version": "^5.0.0"
73+
"standard-version": "^7.0.0"
7474
},
7575
"engines": {
7676
"node": ">=7",

‎rules/react.js

+1
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ module.exports = {
144144
// Enforce component methods order
145145
'react/sort-comp': [2, {
146146
'order': [
147+
'static-variables',
147148
'static-methods',
148149
'static-lifecycle',
149150
'instance-variables',

‎test/__snapshots__/index.spec.js.snap

+19-7
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,7 @@ Array [
466466
"severity": 2,
467467
},
468468
Object {
469-
"column": 6,
469+
"column": 5,
470470
"line": 176,
471471
"rule": "no-extra-boolean-cast",
472472
"severity": 2,
@@ -824,19 +824,25 @@ Array [
824824
Object {
825825
"column": 5,
826826
"line": 5,
827-
"rule": "jsdoc/check-param-names",
827+
"rule": "jsdoc/require-param",
828828
"severity": 2,
829829
},
830830
Object {
831831
"column": 5,
832832
"line": 5,
833+
"rule": "jsdoc/require-param",
834+
"severity": 2,
835+
},
836+
Object {
837+
"column": NaN,
838+
"line": 6,
833839
"rule": "jsdoc/newline-after-description",
834840
"severity": 2,
835841
},
836842
Object {
837-
"column": 5,
838-
"line": 5,
839-
"rule": "jsdoc/require-param",
843+
"column": NaN,
844+
"line": 7,
845+
"rule": "jsdoc/check-param-names",
840846
"severity": 2,
841847
},
842848
Object {
@@ -1126,8 +1132,8 @@ Array [
11261132
"severity": 1,
11271133
},
11281134
Object {
1129-
"column": 5,
1130-
"line": 768,
1135+
"column": 9,
1136+
"line": 769,
11311137
"rule": "react/require-render-return",
11321138
"severity": 2,
11331139
},
@@ -1627,6 +1633,12 @@ Array [
16271633
"rule": "space-in-parens",
16281634
"severity": 2,
16291635
},
1636+
Object {
1637+
"column": 17,
1638+
"line": 1214,
1639+
"rule": "space-in-parens",
1640+
"severity": 2,
1641+
},
16301642
Object {
16311643
"column": 16,
16321644
"line": 1229,

‎test/fixtures/samples/jest/.eslintrc.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
"root": true,
33
"extends": [
44
"../../../../es6.js",
5+
"../../../../addons/es-modules.js",
56
"../../../../addons/jest.js",
6-
"../../../../addons/node.js",
7-
"../../../../addons/es-modules.js"
7+
"../../../../addons/node.js"
88
]
99
}

0 commit comments

Comments
 (0)
Please sign in to comment.