test: removes destructuring, spread, rest syntax and adds lint rules

NODE-2851

Author: Thomas Reggi

.eslintrc.json

@@ -4,7 +4,8 @@
     "ecmaVersion": 2017
   },
   "plugins": [
-    "prettier"
+    "prettier",
+    "es"
   ],
   "extends": [
     "eslint:recommended",
@@ -17,9 +18,12 @@
   },
   "rules": {
     "prettier/prettier": "error",
-
+    "es/no-destructuring": "error",
+    "es/no-rest-spread-properties": "error",
+    "es/no-spread-elements": "error",
     "no-console": "off",
     "eqeqeq": ["error", "always", { "null": "ignore" }],
     "strict": ["error", "global"]
-  }
+  },
+  "ignorePatterns": ["test/benchmarks/*.js", "test/examples/*.js"]
 }

package-lock.json

@@ -38,6 +38,7 @@
     "coveralls": "^2.11.6",
     "eslint": "^7.10.0",
     "eslint-config-prettier": "^6.11.0",
+    "eslint-plugin-es": "^3.0.1",
     "eslint-plugin-prettier": "^3.1.3",
     "istanbul": "^0.4.5",
     "jsdoc": "3.5.5",

package.json

@@ -6,7 +6,7 @@ const setupDatabase = require('./shared').setupDatabase;
 const withMonitoredClient = require('./shared').withMonitoredClient;
 const expect = require('chai').expect;
 const ReadPreference = require('../../lib/core/topologies/read_preference');
-const { withClient } = require('./shared');
+const withClient = require('./shared').withClient;
 
 describe('ReadPreference', function() {
   before(function() {
@@ -702,7 +702,9 @@ describe('ReadPreference', function() {
           return withClient(client, (client, done) => {
             const db = client.db(configuration.db);
             const args = methods[operation];
-            const [parentId, method] = operation.split('#');
+            const split = operation.split('#');
+            const parentId = split[0];
+            const method = split[1];
             const collection = db.collection(collectionName);
             const parent = parentId === 'Collection' ? collection : parentId === 'Db' ? db : null;
             const selectServerSpy = this.sinon.spy(Topology.prototype, 'selectServer');
@@ -720,7 +722,8 @@ describe('ReadPreference', function() {
               }
               done();
             };
-            parent[method].apply(parent, [...args, callback]);
+            args.push(callback);
+            parent[method].apply(parent, args);
           });
         }
       });

test/functional/readpreference.test.js

@@ -1,7 +1,7 @@
 'use strict';
 
-const { expect } = require('chai');
-const { MongoError } = require('../../../index');
+const expect = require('chai').expect;
+const MongoError = require('../../../index').MongoError;
 
 describe('Cursor Async Iterator Tests', function() {
   let client, collection;