Merge pull request #35 from mdvorscak/master

Fix #25, all falsy pattern values and empty arrays are now treated the same

Author: woodyrew

lib/index.js

@@ -201,7 +201,7 @@ function replace(pattern, data, options) {
 
   for (var i = 0, key; (key = keys[i++]); ) {
     var val = data[key];
-    if (val == null) return null;
+    if (!val || Array.isArray(val) && val.length === 0) return null;
     if (val instanceof Date) {
       ret[key] = options.date(val);
     } else {

test/fixtures/empty-array/src/emptyarray.html

@@ -0,0 +1,5 @@
+---
+array: []
+title: test
+---
+test

test/fixtures/falsy/src/emptystring.html

@@ -0,0 +1,5 @@
+---
+falsy: ''
+title: test
+---
+test

test/fixtures/falsy/src/false.html

@@ -0,0 +1,5 @@
+---
+falsy: false
+title: test
+---
+test

test/fixtures/falsy/src/nan.html

@@ -0,0 +1,5 @@
+---
+falsy: .NAN
+title: test
+---
+test

test/fixtures/falsy/src/null.html

@@ -0,0 +1,5 @@
+---
+falsy: null
+title: test
+---
+test

test/fixtures/falsy/src/undefined.html

@@ -0,0 +1,4 @@
+---
+title: test
+---
+test

test/index.js

@@ -183,4 +183,33 @@ describe('metalsmith-permalinks', function() {
         done();
       });
   });
+
+  it('should use the resolve path for false values (not root)', function (done) {
+    Metalsmith('test/fixtures/falsy')
+      .use(permalinks(':falsy/:title'))
+      .use(function (files, metalsmith, pluginDone) {
+        Object.keys(files).forEach(function (file) {
+         assert.notEqual(files[file].path.charAt(0), '/');
+        });
+        done();
+      })
+      .build(function (err) {
+        if (err) return done(err);
+      });
+  });
+
+
+  it('should use the resolve path for empty arrays (not root)', function (done) {
+    Metalsmith('test/fixtures/empty-array')
+      .use(permalinks(':array/:title'))
+      .use(function (files, metalsmith, pluginDone) {
+        Object.keys(files).forEach(function (file) {
+         assert.notEqual(files[file].path.charAt(0), '/');
+        });
+        done();
+      })
+      .build(function (err) {
+        if (err) return done(err);
+      });
+  });
 });