Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fenced code doesn't need a trailing newline #2756

Merged
merged 3 commits into from
Mar 22, 2023
Merged

fix: fenced code doesn't need a trailing newline #2756

merged 3 commits into from
Mar 22, 2023

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Mar 14, 2023 •
edited

Marked version: 4.2.12

Description

Fenced code without closing ticks should consume the rest of the markdown. Currently it doesn't if there is no trailing newline character.

marked demo
commonmark demo

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Mar 14, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 2:23AM (UTC)

@UziTech UziTech mentioned this pull request Mar 14, 2023
Closed
calculuschild
calculuschild requested changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@calculuschild calculuschild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine except I'm not following why this PR includes changes to the /lib files.

lib/marked.cjs Show resolved Hide resolved
@UziTech UziTech merged commit 3acbb7f into markedjs:master Mar 22, 2023
github-actions bot pushed a commit that referenced this pull request Mar 22, 2023
@semantic-release-bot
chore(release): 4.3.0 [skip ci]
d65cf63 
# [4.3.0](v4.2.12...v4.3.0) (2023-03-22)

### Bug Fixes

* always return promise if async ([#2728](#2728)) ([042dcc5](042dcc5))
* fenced code doesn't need a trailing newline ([#2756](#2756)) ([3acbb7f](3acbb7f))

### Features

* add preprocess and postprocess hooks ([#2730](#2730)) ([9b452bc](9b452bc))
@UziTech UziTech deleted the code-no-newline branch August 26, 2023 03:23
This was referenced May 19, 2024
Open
Open
Open
Open
@ragnarstolsmark ragnarstolsmark mentioned this pull request May 24, 2024
Open
@cezaraugusto cezaraugusto mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
This was referenced May 25, 2024
Open
Open
Open
Open
Open
@mkajitansnyk mkajitansnyk mentioned this pull request May 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calculuschild calculuschild calculuschild approved these changes

@joshbruce joshbruce joshbruce approved these changes

@davisjam davisjam Awaiting requested review from davisjam

@styfle styfle Awaiting requested review from styfle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic data rendering with code block creates a flickering in dom
3 participants
@UziTech @calculuschild @joshbruce