fix: chat example with new multiaddr #946
Merged
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Multiaddr update did not bubble up to the chat example 😱 Thanks @mobeiqingkong for pointing this out
The chat example test has been running fine in the CI (last commit: https://github.com/libp2p/js-libp2p/runs/2637518502), but it is using the old multiaddr. After looking into how it is getting the dependencies, I noticed that libp2p examples have some dependencies (
libp2p-pubsub-peer-discoveryandlibp2p-relay-server) that use the older multiaddr and that ends up being the one used in the examples.Needs: