fix: add error handler for incoming connections (#224)

Author: jacobheun

src/index.js

@@ -145,18 +145,19 @@ class WebRTCStar {
       }
 
       const done = (err) => {
-        channel.removeListener('error', onError)
         channel.removeListener('timeout', onTimeout)
         channel.removeListener('connect', onConnect)
         options.signal && options.signal.removeEventListener('abort', onAbort)
 
         err ? reject(err) : resolve(channel)
       }
 
-      channel.once('error', onError)
+      channel.on('error', onError)
       channel.once('timeout', onTimeout)
       channel.once('connect', onConnect)
-      channel.on('close', () => channel.destroy())
+      channel.on('close', () => {
+        channel.removeListener('error', onError)
+      })
       options.signal && options.signal.addEventListener('abort', onAbort)
 
       channel.on('signal', (signal) => {

src/listener.js

@@ -55,6 +55,15 @@ module.exports = ({ handler, upgrader }, WebRTCStar, options = {}) => {
 
       const channel = new SimplePeer(spOptions)
 
+      const onError = (err) => {
+        log.error('incoming connectioned errored', err)
+      }
+
+      channel.on('error', onError)
+      channel.once('close', (...args) => {
+        channel.removeListener('error', onError)
+      })
+
       channel.once('signal', (signal) => {
         offer.signal = signal
         offer.answer = true

src/socket-to-conn.js

@@ -23,7 +23,7 @@ const toWebrtcMultiaddr = (address, port) => {
 }
 
 // Convert a socket into a MultiaddrConnection
-// https://github.com/libp2p/interface-transport#multiaddrconnection
+// https://github.com/libp2p/js-libp2p-interfaces/tree/master/src/transport#multiaddrconnection
 module.exports = (socket, options = {}) => {
   const { sink, source } = toIterable.duplex(socket)