Update knex types for TS 4.7 #5095
Merged
+72
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing. |
|
That should do it, I hope - the explicit |
|
I only changed the types, so I can't really answer why the |
kibertoad
approved these changes
Apr 4, 2022
|
Released in 1.0.5 |
5 tasks
|
Does this mean that downstream projects need also to update their typescript to 4.7? |
|
@glensc I think it should work with earlier version too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly, this involves adding a lot of missing type parameter constraints - in older versions of TS, we'd let an unconstrained type parameter be used where a type parameter extending
{}is expected - in 4.7, we fix this.