Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding with clause in mysql dialect #4508

Merged
merged 9 commits into from
Jan 25, 2022
Merged

adding with clause in mysql dialect #4508

merged 9 commits into from
Jan 25, 2022
+54 −21

Conversation

LucasHFS
Copy link
Contributor

attempt to fix #4428

@LucasHFS LucasHFS force-pushed the 4428_fix_with_update branch from 2e17645 to 5273656 Compare May 28, 2021 13:52
@LucasHFS LucasHFS force-pushed the 4428_fix_with_update branch from 5273656 to a834980 Compare May 28, 2021 14:01
@kibertoad
Copy link
Collaborator

Thanks! Could you add integration test for this?

@LucasHFS
Copy link
Contributor Author

Ok, WIP.

@OlivierCavadenti OlivierCavadenti self-assigned this Jan 16, 2022
@OlivierCavadenti
Copy link
Collaborator

note for me: need to add integration update with test...

@OlivierCavadenti
Copy link
Collaborator

@kibertoad seems one test fail in Mssql, I will fix it later

@OlivierCavadenti OlivierCavadenti merged commit 2467db1 into knex:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad

Assignees

@OlivierCavadenti OlivierCavadenti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

with() doesn't work with update statements?
3 participants
@LucasHFS @kibertoad @OlivierCavadenti