Skip to content

Commit fb76ed6

Browse files
authoredDec 21, 2020
chore(test): remove usage of deprecated buffer API (#3596)
1 parent 35a5842 commit fb76ed6

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed
 

‎test/unit/preprocessor.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ describe('preprocessor', () => {
1111
let mockFs
1212
let emitterSetting
1313
// mimic first few bytes of a pdf file
14-
const binarydata = new Buffer([0x25, 0x50, 0x44, 0x66, 0x46, 0x00]) // eslint-disable-line node/no-deprecated-api
14+
const binarydata = Buffer.from([0x25, 0x50, 0x44, 0x66, 0x46, 0x00])
1515

1616
beforeEach(() => {
1717
mockFs = mocks.fs.create({

‎test/unit/runner.spec.js

+12-12
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ describe('runner', () => {
1414
const EXIT = constant.EXIT_CODE
1515

1616
it('should return 0 exit code if present in the buffer', () => {
17-
const result = m.parseExitCode(new Buffer(`something\nfake${EXIT}10`)) // eslint-disable-line node/no-deprecated-api
17+
const result = m.parseExitCode(Buffer.from(`something\nfake${EXIT}10`))
1818
expect(result.exitCode).to.equal(0)
1919
})
2020

2121
it('should remove the exit code part of the returned buffer', () => {
22-
const buffer = new Buffer(`some${EXIT}01`) // eslint-disable-line node/no-deprecated-api
22+
const buffer = Buffer.from(`some${EXIT}01`)
2323
const result = m.parseExitCode(buffer)
2424

2525
expect(buffer.toString()).to.equal(`some${EXIT}01`)
@@ -28,7 +28,7 @@ describe('runner', () => {
2828

2929
it('should not touch buffer without exit code and return default', () => {
3030
const msg = 'some nice \n messgae {}'
31-
const buffer = new Buffer(msg) // eslint-disable-line node/no-deprecated-api
31+
const buffer = Buffer.from(msg)
3232
const result = m.parseExitCode(buffer, 10)
3333

3434
expect(result.buffer.toString()).to.equal(msg)
@@ -53,21 +53,21 @@ describe('runner', () => {
5353
})
5454

5555
it('should parse any single digit exit code', () => {
56-
expect(m.parseExitCode(new Buffer(`something\nfake${EXIT}01`)).exitCode).to.equal(1) // eslint-disable-line node/no-deprecated-api
57-
expect(m.parseExitCode(new Buffer(`something\nfake${EXIT}17`)).exitCode).to.equal(7) // eslint-disable-line node/no-deprecated-api
56+
expect(m.parseExitCode(Buffer.from(`something\nfake${EXIT}01`)).exitCode).to.equal(1)
57+
expect(m.parseExitCode(Buffer.from(`something\nfake${EXIT}17`)).exitCode).to.equal(7)
5858
})
5959

6060
it('should return exit code 0 if failOnEmptyTestSuite is false and and non-empty int is 0', () => {
61-
expect(m.parseExitCode(new Buffer(`something\nfake${EXIT}01`), undefined, false).exitCode).to.equal(0) // eslint-disable-line node/no-deprecated-api
61+
expect(m.parseExitCode(Buffer.from(`something\nfake${EXIT}01`), undefined, false).exitCode).to.equal(0)
6262
})
6363

6464
it('should return exit code if failOnEmptyTestSuite is true', () => {
65-
expect(m.parseExitCode(new Buffer(`something\nfake${EXIT}00`), undefined, true).exitCode).to.equal(0) // eslint-disable-line node/no-deprecated-api
66-
expect(m.parseExitCode(new Buffer(`something\nfake${EXIT}01`), undefined, true).exitCode).to.equal(1) // eslint-disable-line node/no-deprecated-api
67-
expect(m.parseExitCode(new Buffer(`something\nfake${EXIT}07`), undefined, true).exitCode).to.equal(7) // eslint-disable-line node/no-deprecated-api
68-
expect(m.parseExitCode(new Buffer(`something\nfake${EXIT}10`), undefined, true).exitCode).to.equal(0) // eslint-disable-line node/no-deprecated-api
69-
expect(m.parseExitCode(new Buffer(`something\nfake${EXIT}11`), undefined, true).exitCode).to.equal(1) // eslint-disable-line node/no-deprecated-api
70-
expect(m.parseExitCode(new Buffer(`something\nfake${EXIT}17`), undefined, true).exitCode).to.equal(7) // eslint-disable-line node/no-deprecated-api
65+
expect(m.parseExitCode(Buffer.from(`something\nfake${EXIT}00`), undefined, true).exitCode).to.equal(0)
66+
expect(m.parseExitCode(Buffer.from(`something\nfake${EXIT}01`), undefined, true).exitCode).to.equal(1)
67+
expect(m.parseExitCode(Buffer.from(`something\nfake${EXIT}07`), undefined, true).exitCode).to.equal(7)
68+
expect(m.parseExitCode(Buffer.from(`something\nfake${EXIT}10`), undefined, true).exitCode).to.equal(0)
69+
expect(m.parseExitCode(Buffer.from(`something\nfake${EXIT}11`), undefined, true).exitCode).to.equal(1)
70+
expect(m.parseExitCode(Buffer.from(`something\nfake${EXIT}17`), undefined, true).exitCode).to.equal(7)
7171
})
7272
})
7373
})

0 commit comments

Comments
 (0)
Please sign in to comment.