Skip to content

Commit 653c762

Browse files
author
Jonathan Ginsburg
committedFeb 5, 2022
ci: prevent duplicate CI tasks on creating a PR
BrowserStack can be flaky when there are multiple concurrent jobs running on it. This commit makes sure that only 1 browser can run concurrently during the `npm run test:client` jobs and that the "Test" GitHub Action workflow is only trigerred once when creating a PR; having the `on: push` configuration made it so that GH triggers two duplicate jobs when a PR is opened.
1 parent c97e562 commit 653c762

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed
 

‎.github/workflows/test.yml

+1-4
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
name: Test
22

33
on:
4-
push:
5-
branches-ignore:
6-
- master
74
pull_request:
85
branches:
96
- master
@@ -38,7 +35,7 @@ jobs:
3835
runs-on: ubuntu-latest
3936
strategy:
4037
matrix:
41-
node: [ 10, 12 ]
38+
node: [10, 12]
4239
steps:
4340
- uses: actions/checkout@v2
4441
- uses: actions/setup-node@v2

‎test/client/karma.conf.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ module.exports = function (config) {
124124
'karma-browserstack-launcher'
125125
],
126126

127-
concurrency: 2,
127+
concurrency: 1,
128128

129129
forceJSONP: true,
130130

0 commit comments

Comments
 (0)
Please sign in to comment.