Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useLocalStorage complies with useState #242

Closed
wants to merge 1 commit into from
Closed

useLocalStorage complies with useState #242

wants to merge 1 commit into from
+16 −2

Conversation

valyrie97
Copy link

Fixes #204

  • add a test (that verified the issue)
  • changed the parameter of the setState callback function to get a fresh value from localstorage.

@henriqemalheiros
Copy link

Ran into the same issue. useSessionStorage also has this problem.

@henriqemalheiros henriqemalheiros mentioned this pull request Jan 5, 2023
Closed
@valyrie97
Copy link
Author

valyrie97 commented Jan 5, 2023 •
edited
Loading

@henriqemalheiros I'm happy to take a look at it and PR when i get a chance. could you create a separate issue and @ me?

@justinmetros justinmetros mentioned this pull request Jan 25, 2023
Closed
@wayneschuller
Copy link

This bug is causing me headaches! Would love to see the PR accepted...

@juliencrn juliencrn added the bug Something isn't working label Jan 23, 2024
juliencrn added a commit that referenced this pull request Jan 23, 2024
@juliencrn
🐛 make useLocalStorage and useSessionStorage compliant with useState (f…
b93ab2d 
…ixes #204 with #242 by @valyrie97)
@juliencrn juliencrn mentioned this pull request Jan 23, 2024
Merged
juliencrn added a commit that referenced this pull request Jan 23, 2024
@juliencrn
🐛 make useLocalStorage and useSessionStorage compliant with useState (f…
e8aa777 
…ixes #204 with #242 by @valyrie97) (#436)
@juliencrn
Copy link
Owner

Thanks @valyrie97 that's perfect 👌
As the base branch is a bit outdated, I applied your change here #436 on both useLocalStorage and useSessionStorage

@juliencrn juliencrn closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useLocalStorage set function does not entirely comply with useState
4 participants
@valyrie97 @henriqemalheiros @wayneschuller @juliencrn