Skip to content

Commit d6f39b0

Browse files
committedOct 2, 2024··
Fix tests for old node
1 parent 6bb701f commit d6f39b0

File tree

1 file changed

+21
-25
lines changed

1 file changed

+21
-25
lines changed
 

‎test/serialize.js

+21-25
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ describe('cookie.serialize(name, value)', function () {
3636
'foo7bar',
3737
];
3838

39-
validNames.forEach((name) => {
40-
assert.equal(cookie.serialize(name, 'baz'), `${name}=baz`, `Expected serialized value for name: "${name}"`);
39+
validNames.forEach(function (name) {
40+
assert.equal(cookie.serialize(name, 'baz'), name + '=baz');
4141
});
4242
});
4343

@@ -52,19 +52,18 @@ describe('cookie.serialize(name, value)', function () {
5252
'foo[foo]',
5353
'foo?foo',
5454
'foo:foo',
55-
'foo!foo',
5655
'foo{foo}',
5756
'foo foo',
5857
'foo\tfoo',
5958
'foo"foo',
6059
'foo<script>foo'
6160
];
6261

63-
invalidNames.forEach((name) => {
62+
invalidNames.forEach(function (name) {
6463
assert.throws(
6564
cookie.serialize.bind(cookie, name, 'bar'),
6665
/argument name is invalid/,
67-
`Expected an error for invalid name: "${name}"`
66+
'Expected an error for invalid name: ' + name
6867
);
6968
});
7069
});
@@ -74,24 +73,23 @@ describe('cookie.serialize(name, value, options)', function () {
7473
describe('with "domain" option', function () {
7574

7675
it('should serialize valid domain', function () {
77-
const validDomains = [
76+
var validDomains = [
7877
'example.com',
7978
'sub.example.com',
8079
'my-site.org',
8180
'localhost'
8281
];
8382

84-
validDomains.forEach((domain) => {
83+
validDomains.forEach(function (domain) {
8584
assert.equal(
86-
cookie.serialize('foo', 'bar', { domain }),
87-
`foo=bar; Domain=${domain}`,
88-
`Expected serialized value for domain: "${domain}"`
85+
cookie.serialize('foo', 'bar', { domain: domain }),
86+
'foo=bar; Domain=' + domain
8987
);
9088
});
9189
});
9290

9391
it('should throw for invalid domain', function () {
94-
const invalidDomains = [
92+
var invalidDomains = [
9593
'example.com\n',
9694
'sub.example.com\u0000',
9795
'my site.org',
@@ -101,11 +99,11 @@ describe('cookie.serialize(name, value, options)', function () {
10199
'example.com /* inject a comment */'
102100
];
103101

104-
invalidDomains.forEach((domain) => {
102+
invalidDomains.forEach(function (domain) {
105103
assert.throws(
106-
cookie.serialize.bind(cookie, 'foo', 'bar', { domain }),
104+
cookie.serialize.bind(cookie, 'foo', 'bar', { domain: domain }),
107105
/option domain is invalid/,
108-
`Expected an error for invalid domain: "${domain}"`
106+
'Expected an error for invalid domain: ' + domain
109107
);
110108
});
111109
});
@@ -207,7 +205,7 @@ describe('cookie.serialize(name, value, options)', function () {
207205

208206
describe('with "path" option', function () {
209207
it('should serialize path', function () {
210-
const validPaths = [
208+
var validPaths = [
211209
'/',
212210
'/login',
213211
'/foo.bar/baz',
@@ -219,31 +217,29 @@ describe('cookie.serialize(name, value, options)', function () {
219217
'./'
220218
];
221219

222-
validPaths.forEach((path) => {
220+
validPaths.forEach(function (path) {
223221
assert.equal(
224-
cookie.serialize('foo', 'bar', { path }),
225-
`foo=bar; Path=${path}`,
226-
`Expected serialized value for path: "${path}"`
222+
cookie.serialize('foo', 'bar', { path: path }),
223+
'foo=bar; Path=' + path,
224+
'Expected serialized value for path: ' + path
227225
);
228226
});
229227
});
230228

231229
it('should throw for invalid value', function () {
232-
const invalidPaths = [
230+
var invalidPaths = [
233231
'/\n',
234232
'/foo\u0000',
235-
'/foo bar',
236233
'/path/with\rnewline',
237-
'/path\\with\\backslash',
238234
'/; Path=/sensitive-data',
239235
'/login"><script>alert(1)</script>'
240236
];
241237

242-
invalidPaths.forEach((path) => {
238+
invalidPaths.forEach(function (path) {
243239
assert.throws(
244-
cookie.serialize.bind(cookie, 'foo', 'bar', { path }),
240+
cookie.serialize.bind(cookie, 'foo', 'bar', { path: path }),
245241
/option path is invalid/,
246-
`Expected an error for invalid path: "${path}"`
242+
'Expected an error for invalid path: ' + path
247243
);
248244
});
249245
});

0 commit comments

Comments
 (0)
Please sign in to comment.