Runtime deprecation warnings for methods that will be removed in 4.0

Author: sgravrock

lib/jasmine.js

@@ -336,7 +336,7 @@ Jasmine.prototype.loadConfig = function(config) {
    * @type string[] | undefined
    */
   if(config.helpers) {
-    this.addHelperFiles(config.helpers);
+    this.addMatchingHelperFiles(config.helpers);
   }
 
   /**
@@ -356,7 +356,7 @@ Jasmine.prototype.loadConfig = function(config) {
    * @type string[] | undefined
    */
   if(config.spec_files) {
-    this.addSpecFiles(config.spec_files);
+    this.addMatchingSpecFiles(config.spec_files);
   }
 };
 
@@ -392,7 +392,12 @@ Jasmine.prototype.addMatchingHelperFiles = addFiles('helperFiles');
  * {@link Jasmine#loadConfig|loadConfig}, or {@link Jasmine#loadConfigFile|loadConfigFile}
  * instead.
  */
-Jasmine.prototype.addSpecFiles = Jasmine.prototype.addMatchingSpecFiles;
+Jasmine.prototype.addSpecFiles = function(globs) {
+  this.env.deprecated('jasmine#addSpecFiles is deprecated. Use ' +
+    'jasmine#addMatchingSpecFiles instead.');
+  this.addMatchingSpecFiles(globs);
+};
+
 /**
  * Synonym for {@link Jasmine#addMatchingHelperFiles}
  * @name Jasmine#addHelperFiles
@@ -401,7 +406,11 @@ Jasmine.prototype.addSpecFiles = Jasmine.prototype.addMatchingSpecFiles;
  * {@link Jasmine#loadConfig|loadConfig}, or {@link Jasmine#loadConfigFile|loadConfigFile}
  * instead.
  */
-Jasmine.prototype.addHelperFiles = Jasmine.prototype.addMatchingHelperFiles;
+Jasmine.prototype.addHelperFiles = function(globs) {
+  this.env.deprecated('jasmine#addHelperFiles is deprecated. Use ' +
+    'jasmine#addMatchingHelperFiles instead.');
+  this.addMatchingHelperFiles(globs);
+};
 
 Jasmine.prototype.addRequires = function(requires) {
   const jasmineRunner = this;
@@ -569,7 +578,7 @@ Jasmine.prototype.execute = async function(files, filterString) {
   if (files && files.length > 0) {
     this.specDir = '';
     this.specFiles = [];
-    this.addSpecFiles(files);
+    this.addMatchingSpecFiles(files);
   }
 
   await this.loadSpecs();

spec/jasmine_spec.js

@@ -56,15 +56,39 @@ describe('Jasmine', function() {
 
   describe('Methods that specify files via globs', function() {
     describe('#addSpecFiles', function() {
+      beforeEach(function() {
+        this.testJasmine.env.deprecated = jasmine.createSpy('env.deprecated');
+      });
+
       hasCommonFileGlobBehavior('addSpecFiles', 'specFiles');
+
+      it('issues a deprecation warning', function() {
+        this.testJasmine.addSpecFiles([]);
+        expect(this.testJasmine.env.deprecated).toHaveBeenCalledWith(
+          'jasmine#addSpecFiles is deprecated. Use ' +
+            'jasmine#addMatchingSpecFiles instead.'
+        );
+      });
     });
 
     describe('#addMatchingSpecFiles', function() {
       hasCommonFileGlobBehavior('addMatchingSpecFiles', 'specFiles');
     });
 
     describe('#addHelperFiles', function() {
+      beforeEach(function() {
+        this.testJasmine.env.deprecated = jasmine.createSpy('env.deprecated');
+      });
+
       hasCommonFileGlobBehavior('addHelperFiles', 'helperFiles');
+
+      it('issues a deprecation warning', function() {
+        this.testJasmine.addHelperFiles([]);
+        expect(this.testJasmine.env.deprecated).toHaveBeenCalledWith(
+          'jasmine#addHelperFiles is deprecated. Use ' +
+            'jasmine#addMatchingHelperFiles instead.'
+        );
+      });
     });
 
     describe('#addMatchingHelperFiles', function() {