Log a deprecation when a require has a path starting with . or ..

Author: sgravrock

lib/jasmine.js

@@ -105,6 +105,12 @@ Jasmine.prototype.loadRequires = function() {
   // TODO: In 4.0, switch to calling _loadFiles
   // (requires making this function async)
   this.requires.forEach(function(r) {
+    if (r.startsWith('./') || r.startsWith("../")) {
+      console.warn('DEPRECATION: requires with relative paths (in this case ' +
+        `${r}) are currently resolved relative to the jasmine/lib/jasmine ` +
+        'module but will be relative to the current working directory in ' +
+        'Jasmine 4.0.');
+    }
     require(r);
   });
 };

spec/jasmine_spec.js

@@ -333,6 +333,34 @@ describe('Jasmine', function() {
           expect(this.loader.load).toHaveBeenCalledWith(jasmine.any(String), false);
         });
       });
+
+      it('logs a deprecation when a require has a path beginning with ../', function() {
+        this.configObject.requires = ['../somefile.js'];
+        spyOn(console, 'warn');
+
+        this.fixtureJasmine.loadConfig(this.configObject);
+        expect(() => this.fixtureJasmine.loadRequires())
+          .toThrowError(/^Cannot find module '\.\.\/somefile.js'/);
+
+        expect(console.warn).toHaveBeenCalledWith('DEPRECATION: requires ' +
+          'with relative paths (in this case ../somefile.js) are currently ' +
+          'resolved relative to the jasmine/lib/jasmine module but will be ' +
+          'relative to the current working directory in Jasmine 4.0.');
+      });
+
+      it('logs a deprecation when a require has a path beginning with ./', function() {
+        this.configObject.requires = ['./somefile.js'];
+        spyOn(console, 'warn');
+
+        this.fixtureJasmine.loadConfig(this.configObject);
+        expect(() => this.fixtureJasmine.loadRequires())
+          .toThrowError(/^Cannot find module '\.\/somefile.js'/);
+
+        expect(console.warn).toHaveBeenCalledWith('DEPRECATION: requires ' +
+          'with relative paths (in this case ./somefile.js) are currently ' +
+          'resolved relative to the jasmine/lib/jasmine module but will be ' +
+          'relative to the current working directory in Jasmine 4.0.');
+      });
     });
 
     describe('from a file', function() {