- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 486
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: isaacs/node-glob
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f5a57d3d6e19b324522a3fa5bdd5075fd1aa79d1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: isaacs/node-glob
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a68703e61894ef260323dcc9f95b21f17197d951
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
6
contributors
Commits on May 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 37b44c1 - Browse repository at this point
Copy the full SHA 37b44c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66c102e - Browse repository at this point
Copy the full SHA 66c102eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce43ea0 - Browse repository at this point
Copy the full SHA ce43ea0View commit details
Commits on Sep 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for df4598a - Browse repository at this point
Copy the full SHA df4598aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bfec21 - Browse repository at this point
Copy the full SHA 3bfec21View commit details
Commits on Feb 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 73feafd - Browse repository at this point
Copy the full SHA 73feafdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 965f939 - Browse repository at this point
Copy the full SHA 965f939View commit details
Commits on Feb 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bd836b7 - Browse repository at this point
Copy the full SHA bd836b7View commit details -
chore: add copyright year to license
License Year Bot committedFeb 27, 2022 Configuration menu - View commit details
-
Copy full SHA for 6d02131 - Browse repository at this point
Copy the full SHA 6d02131View commit details
Commits on Mar 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8b5eb93 - Browse repository at this point
Copy the full SHA 8b5eb93View commit details
Commits on Mar 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3d6c4cd - Browse repository at this point
Copy the full SHA 3d6c4cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ad3bbf - Browse repository at this point
Copy the full SHA 6ad3bbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0004d83 - Browse repository at this point
Copy the full SHA 0004d83View commit details
Commits on Apr 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for af3eb8a - Browse repository at this point
Copy the full SHA af3eb8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 55ebc0b - Browse repository at this point
Copy the full SHA 55ebc0bView commit details
Commits on Apr 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7eab927 - Browse repository at this point
Copy the full SHA 7eab927View commit details
Commits on May 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5630197 - Browse repository at this point
Copy the full SHA 5630197View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8a3682 - Browse repository at this point
Copy the full SHA a8a3682View commit details
Commits on May 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0049e9a - Browse repository at this point
Copy the full SHA 0049e9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for af4207b - Browse repository at this point
Copy the full SHA af4207bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d13cb06 - Browse repository at this point
Copy the full SHA d13cb06View commit details
Commits on May 13, 2022
-
[Refactor] use more explicit
assert.ok
PR-URL: #451 Credit: @ljharb Close: #451 Reviewed-by: @nicolas377
Configuration menu - View commit details
-
Copy full SHA for fc717ba - Browse repository at this point
Copy the full SHA fc717baView commit details -
Configuration menu - View commit details
-
Copy full SHA for d844b2c - Browse repository at this point
Copy the full SHA d844b2cView commit details
Commits on May 16, 2022
-
Remove dependency on path-is-absolute
Per https://www.npmjs.com/package/path-is-absolute: > This package is no longer relevant as Node.js 0.12 is unmaintained. PR-URL: #477 Credit: @jsha Close: #477 Reviewed-by: @isaacs
Configuration menu - View commit details
-
Copy full SHA for e19db65 - Browse repository at this point
Copy the full SHA e19db65View commit details -
Configuration menu - View commit details
-
Copy full SHA for af57da2 - Browse repository at this point
Copy the full SHA af57da2View commit details
Commits on Jan 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1756fcc - Browse repository at this point
Copy the full SHA 1756fccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b6bf20 - Browse repository at this point
Copy the full SHA 1b6bf20View commit details -
chore: add copyright year to license
License Year Bot committedJan 14, 2023 Configuration menu - View commit details
-
Copy full SHA for 3a5a70a - Browse repository at this point
Copy the full SHA 3a5a70aView commit details
Commits on Feb 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 187305f - Browse repository at this point
Copy the full SHA 187305fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8a000f - Browse repository at this point
Copy the full SHA c8a000fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e294d2a - Browse repository at this point
Copy the full SHA e294d2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for edd85fa - Browse repository at this point
Copy the full SHA edd85faView commit details -
Configuration menu - View commit details
-
Copy full SHA for d77081a - Browse repository at this point
Copy the full SHA d77081aView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf01af4 - Browse repository at this point
Copy the full SHA cf01af4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c3ec00 - Browse repository at this point
Copy the full SHA 9c3ec00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d16dfe - Browse repository at this point
Copy the full SHA 8d16dfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3b9bd1 - Browse repository at this point
Copy the full SHA d3b9bd1View commit details -
Too annoying to keep having to run test-regen in dev. Also, use t.testdir() in the one test that was writing and tearing down its fixture manually.
Configuration menu - View commit details
-
Copy full SHA for 392c4b7 - Browse repository at this point
Copy the full SHA 392c4b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b11879 - Browse repository at this point
Copy the full SHA 9b11879View commit details -
Configuration menu - View commit details
-
Copy full SHA for 622a8d0 - Browse repository at this point
Copy the full SHA 622a8d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0db317 - Browse repository at this point
Copy the full SHA a0db317View commit details -
Configuration menu - View commit details
-
Copy full SHA for c381907 - Browse repository at this point
Copy the full SHA c381907View commit details -
Configuration menu - View commit details
-
Copy full SHA for f66a08a - Browse repository at this point
Copy the full SHA f66a08aView commit details -
fix: bundling library using webpack
this change ensures "default" conditions are last, fixing the following webpack bundling error: ``` Module not found: Error: Default condition should be last one ``` Re: isaacs/minimatch#190 Credit: @AviVahl Reviewed-by: @isaacs
Configuration menu - View commit details
-
Copy full SHA for 9bc4065 - Browse repository at this point
Copy the full SHA 9bc4065View commit details -
Only show the real time, and include glob v7/v8 for comparison.
Configuration menu - View commit details
-
Copy full SHA for 0142c85 - Browse repository at this point
Copy the full SHA 0142c85View commit details -
Avoid creating unnecessary stack traces
This makes the glob.sync method MUCH faster, like >30% faster in the benchmark. This implementation is now considerably ahead of v7 and v8.
Configuration menu - View commit details
-
Copy full SHA for a9bbbaa - Browse repository at this point
Copy the full SHA a9bbbaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 59a9700 - Browse repository at this point
Copy the full SHA 59a9700View commit details -
Quite a lot, actually. Still a pathological case where a '**' pattern is followed by multiple glob patterns, especially if the subsequent set of patterns includes another globstar with the same problem, it seems to grow geometrically. So '**/*/*.txt' takes about twice as long as it should, and '**/*/**/*/*.txt' takes about twice as long again, increasining geometrically. Need to rethink the globstar handling approach, maybe the whole shape of the walker class. Currently, it's pretty naive, and the proof of concept I added to test my assumption only works if there'e exactly 1 path portion following the globstar. That is, it makes **/*.txt go as fast as it should, but **/*/*.txt is still slow. Right now, a test for **/*/*.txt in a path a/b/c, with directory child paths [d, e] will create child walkers for the following paths/patterns: */*.txt a/b/c Test without the ** portion, against this path **/*/*.txt a/b/c/d Test with the globstar in each child directory **/*/*.txt a/b/c/e */*.txt a/b/c/d Test without globstar in each child directory */*.txt a/b/c/e This happens at each directory level, so if d and e both have directory children x and y, you get: */*.txt a/b/c/d **/*/*.txt a/b/c/d/x **/*/*.txt a/b/c/d/y */*.txt a/b/c/d/x */*.txt a/b/c/d/y */*.txt a/b/c/e **/*/*.txt a/b/c/e/x **/*/*.txt a/b/c/e/y */*.txt a/b/c/e/x */*.txt a/b/c/e/y Added a check when there's exactly 1 entry after the globstar, but this actually has a bug and isn't scalable anyway.
Configuration menu - View commit details
-
Copy full SHA for fe5efba - Browse repository at this point
Copy the full SHA fe5efbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e7291e - Browse repository at this point
Copy the full SHA 8e7291eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 732430a - Browse repository at this point
Copy the full SHA 732430aView commit details
There are no files selected for viewing
This file was deleted.
This file was deleted.