fix: update monorepo detection and use (#1155)

Remove assumption that monorepos use lerna

Author: achingbrain

src/check-project/check-monorepo-files.js

@@ -15,20 +15,6 @@ const __dirname = path.dirname(fileURLToPath(import.meta.url))
 export async function checkMonorepoFiles (projectDir) {
   console.info('Check monorepo files')
 
-  const pkg = fs.readJSONSync(path.join(projectDir, 'package.json'))
-
-  let defaultLernaContent = fs.readFileSync(path.join(__dirname, 'files/lerna.json'), {
-    encoding: 'utf-8'
-  })
-
-  // ensure lerna version is in sync
-  const lernaConfig = JSON.parse(defaultLernaContent)
-  lernaConfig.lerna = pkg.dependencies.lerna.replace(/\^/, '')
-
-  defaultLernaContent = JSON.stringify(lernaConfig, null, 2)
-
-  await ensureFileHasContents(projectDir, 'lerna.json', defaultLernaContent)
-
   // disable package-lock.json in monorepos until https://github.com/semantic-release/github/pull/487 is merged
   await ensureFileHasContents(projectDir, '.npmrc', fs.readFileSync(path.join(__dirname, 'files/npmrc'), {
     encoding: 'utf-8'

src/check-project/files/lerna.json

@@ -44,7 +44,11 @@ const dependsOn = (name, pkg) => {
  * @param {string} targetDir
  */
 const isMonoRepo = (targetDir) => {
-  return fs.existsSync(path.join(targetDir, 'lerna.json'))
+  const modulePkgPath = path.join(targetDir, 'package.json')
+  const modulePkg = fs.readJSONSync(modulePkgPath)
+
+  // monorepos declare workspaces in their root package.json
+  return Boolean(modulePkg.workspaces)
 }
 
 /**
@@ -185,32 +189,15 @@ const testRepo = async (targetDir, deps, scriptName) => {
 const testMonoRepo = async (targetDir, deps, scriptName) => {
   await installDependencies(targetDir)
 
-  let lerna = path.join('node_modules', '.bin', 'lerna')
-
-  if (!fs.existsSync(lerna)) {
-    // no lerna in project dependencies :(
-    await exec('npm', ['install', '-g', 'lerna'], {
-      cwd: targetDir
-    })
-    lerna = 'lerna'
-  }
-
-  await exec(lerna, ['bootstrap'], {
-    cwd: targetDir
-  })
-
   // read package targetDir config
-  const config = await fs.readJSON(path.join(targetDir, 'lerna.json'))
-
-  // find where the packages are stored
-  let packages = config.packages || 'packages'
+  const config = await fs.readJSON(path.join(targetDir, 'package.json'))
 
-  if (!Array.isArray(packages)) {
-    packages = [packages]
+  if (config.workspaces == null) {
+    throw new Error('Package config did not contain workspaces')
   }
 
-  // test each package that depends on ipfs/http client
-  for (const pattern of packages) {
+  // test each package that depends on passed deps
+  for (const pattern of config.workspaces) {
     for await (const match of glob(targetDir, pattern)) {
       await testModule(path.join(targetDir, match), deps, scriptName)
     }

src/test-dependant/index.js

@@ -1,7 +1,7 @@
 {
   "name": "monorepo",
   "version": "1.0.0",
-  "devDependencies": {
-    "lerna": "^3.20.2"
-  }
+  "workspaces": [
+    "packages/*"
+  ]
 }