Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: import-js/eslint-plugin-import
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 20c373c509ad33e339b96fc38b0daaef8c5f6e9a
Choose a base ref
...
head repository: import-js/eslint-plugin-import
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 924b435072a75529a56e678f2382b31821633b0b
Choose a head ref
Loading
Showing with 2,956 additions and 1,609 deletions.
  1. +3 −3 .babelrc
  2. +1 −1 .eslintrc
  3. +1 −1 .github/FUNDING.yml
  4. +6 −1 .github/workflows/node-4+.yml
  5. +1 −1 .github/workflows/packages.yml
  6. +568 −421 CHANGELOG.md
  7. +13 −5 README.md
  8. +8 −8 RELEASE.md
  9. +5 −3 docs/rules/extensions.md
  10. +1 −1 docs/rules/first.md
  11. +1 −1 docs/rules/imports-first.md
  12. +30 −8 docs/rules/max-dependencies.md
  13. +5 −3 docs/rules/named.md
  14. +1 −1 docs/rules/no-cycle.md
  15. +1 −1 docs/rules/no-duplicates.md
  16. +11 −0 docs/rules/no-namespace.md
  17. +1 −1 docs/rules/no-unresolved.md
  18. +1 −1 docs/rules/no-unused-modules.md
  19. +1 −1 docs/rules/no-useless-path-segments.md
  20. +21 −0 docs/rules/order.md
  21. +1 −1 docs/rules/unambiguous.md
  22. +3 −3 memo-parser/package.json
  23. +12 −11 package.json
  24. +17 −7 resolvers/node/CHANGELOG.md
  25. +26 −7 resolvers/node/index.js
  26. +4 −4 resolvers/node/package.json
  27. +4 −0 resolvers/node/test/package-mains/jsnext/package.json
  28. 0 resolvers/node/test/package-mains/jsnext/src/index.js
  29. +5 −0 resolvers/node/test/package-mains/module-and-jsnext/package.json
  30. 0 resolvers/node/test/package-mains/module-and-jsnext/src/index.js
  31. +1 −0 resolvers/node/test/package-mains/module-broken/main.js
  32. +4 −0 resolvers/node/test/package-mains/module-broken/package.json
  33. +4 −0 resolvers/node/test/package-mains/module/package.json
  34. 0 resolvers/node/test/package-mains/module/src/index.js
  35. +1 −0 resolvers/node/test/package-mains/package.json
  36. +32 −0 resolvers/node/test/packageMains.js
  37. +35 −35 resolvers/webpack/CHANGELOG.md
  38. +14 −15 resolvers/webpack/index.js
  39. +5 −5 resolvers/webpack/package.json
  40. +5 −0 resolvers/webpack/test/package-mains/module-and-jsnext/package.json
  41. 0 resolvers/webpack/test/package-mains/module-and-jsnext/src/index.js
  42. +1 −0 resolvers/webpack/test/package-mains/module-broken/main.js
  43. +4 −0 resolvers/webpack/test/package-mains/module-broken/package.json
  44. +18 −9 resolvers/webpack/test/packageMains.js
  45. +53 −35 src/ExportMap.js
  46. +1 −1 src/core/importType.js
  47. +7 −3 src/core/packagePath.js
  48. +1 −1 src/docsUrl.js
  49. +1 −1 src/rules/dynamic-import-chunkname.js
  50. +2 −2 src/rules/extensions.js
  51. +1 −1 src/rules/first.js
  52. +12 −6 src/rules/max-dependencies.js
  53. +90 −24 src/rules/named.js
  54. +6 −6 src/rules/namespace.js
  55. +3 −3 src/rules/newline-after-import.js
  56. +1 −1 src/rules/no-commonjs.js
  57. +1 −1 src/rules/no-cycle.js
  58. +30 −7 src/rules/no-duplicates.js
  59. +30 −3 src/rules/no-dynamic-require.js
  60. +70 −24 src/rules/no-extraneous-dependencies.js
  61. +9 −3 src/rules/no-import-module-exports.js
  62. +24 −7 src/rules/no-namespace.js
  63. +1 −1 src/rules/no-relative-packages.js
  64. +1 −1 src/rules/no-relative-parent-imports.js
  65. +1 −1 src/rules/no-restricted-paths.js
  66. +1 −1 src/rules/no-self-import.js
  67. +1 −1 src/rules/no-unassigned-import.js
  68. +16 −15 src/rules/no-unresolved.js
  69. +2 −2 src/rules/no-unused-modules.js
  70. +1 −1 src/rules/no-useless-path-segments.js
  71. +2 −4 src/rules/order.js
  72. +1 −2 src/rules/prefer-default-export.js
  73. +9 −0 tests/.eslintrc
  74. +0 −8 tests/.eslintrc.yml
  75. +8 −7 tests/dep-time-travel.sh
  76. +0 −2 tests/files/cycles/depth-one.js
  77. +2 −0 tests/files/cycles/es6/depth-one.js
  78. 0 tests/files/cycles/{ → es6}/depth-three-indirect.js
  79. 0 tests/files/cycles/{ → es6}/depth-three-star.js
  80. 0 tests/files/cycles/{ → es6}/depth-two.js
  81. +1 −1 tests/files/cycles/flow-types-depth-two.js
  82. +1 −0 tests/files/export-star-2/middle.js
  83. +1 −0 tests/files/export-star-2/upstream.js
  84. +1 −0 tests/files/export-star-3/b.ts
  85. 0 tests/files/export-star-3/c.ts
  86. +1 −0 tests/files/export-star/extfield.js
  87. +1 −0 tests/files/export-star/extfield2.js
  88. +2 −0 tests/files/export-star/models.js
  89. +2 −4 tests/files/foo-bar-resolver-no-version.js
  90. +6 −8 tests/files/foo-bar-resolver-v1.js
  91. +4 −6 tests/files/foo-bar-resolver-v2.js
  92. +3 −0 tests/files/missing-entrypoint/package.json
  93. 0 tests/files/node_modules/esm-package-not-in-pkg-json/esm-module/index.js
  94. +4 −0 tests/files/node_modules/esm-package-not-in-pkg-json/esm-module/package.json
  95. 0 tests/files/node_modules/esm-package-not-in-pkg-json/index.js
  96. +5 −0 tests/files/node_modules/esm-package-not-in-pkg-json/package.json
  97. 0 tests/files/node_modules/esm-package/esm-module/index.js
  98. +4 −0 tests/files/node_modules/esm-package/esm-module/package.json
  99. 0 tests/files/node_modules/esm-package/index.js
  100. +5 −0 tests/files/node_modules/esm-package/package.json
  101. +1 −0 tests/files/node_modules/rxjs/index.js
  102. +1 −0 tests/files/node_modules/rxjs/operators/index.js
  103. +5 −0 tests/files/node_modules/rxjs/operators/package.json
  104. +5 −0 tests/files/node_modules/rxjs/package.json
  105. +3 −1 tests/files/package.json
  106. +19 −0 tests/files/typescript-export-react-test-renderer/index.d.ts
  107. +5 −0 tests/files/typescript-export-react-test-renderer/tsconfig.json
  108. +3 −3 tests/files/typescript.ts
  109. +2 −1 tests/files/webpack.config.js
  110. +9 −0 tests/src/cli.js
  111. +1 −1 tests/src/config/typescript.js
  112. +2 −2 tests/src/core/docsUrl.js
  113. +12 −5 tests/src/core/getExports.js
  114. +10 −1 tests/src/core/importType.js
  115. +154 −0 tests/src/core/resolve.js
  116. +11 −0 tests/src/rules/default.js
  117. +10 −0 tests/src/rules/extensions.js
  118. +74 −69 tests/src/rules/first.js
  119. +56 −1 tests/src/rules/max-dependencies.js
  120. +142 −89 tests/src/rules/named.js
  121. +13 −1 tests/src/rules/namespace.js
  122. +1 −1 tests/src/rules/newline-after-import.js
  123. +1 −1 tests/src/rules/no-amd.js
  124. +1 −1 tests/src/rules/no-commonjs.js
  125. +113 −103 tests/src/rules/no-cycle.js
  126. +100 −22 tests/src/rules/no-duplicates.js
  127. +84 −0 tests/src/rules/no-dynamic-require.js
  128. +24 −1 tests/src/rules/no-extraneous-dependencies.js
  129. +7 −0 tests/src/rules/no-import-module-exports.js
  130. +1 −0 tests/src/rules/no-namespace.js
  131. +3 −3 tests/src/rules/no-unresolved.js
  132. +366 −187 tests/src/rules/no-unused-modules.js
  133. +1 −1 tests/src/rules/no-useless-path-segments.js
  134. +333 −274 tests/src/rules/order.js
  135. +29 −47 tests/src/rules/prefer-default-export.js
  136. +3 −0 tests/src/utils.js
  137. +5 −0 utils/.eslintrc
  138. +32 −25 utils/CHANGELOG.md
  139. +2 −2 utils/moduleVisitor.js
  140. +4 −4 utils/package.json
  141. +2 −6 utils/parse.js
  142. +1 −4 utils/resolve.js
6 changes: 3 additions & 3 deletions .babelrc
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
{
"presets": [ "es2015-argon" ],
"presets": ["airbnb"],
"sourceMaps": "inline",
"retainLines": true,
"env": {
"test": {
"plugins": [
"istanbul",
[ "module-resolver", { "root": [ "./src/" ] } ]
["module-resolver", { "root": ["./src/"] }],
]
},
"testCompiled": {
"plugins": [
[ "module-resolver", { "root": [ "./lib/" ] } ]
["module-resolver", { "root": ["./lib/"] }],
]
}
}
2 changes: 1 addition & 1 deletion .eslintrc
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
},
"parserOptions": {
"sourceType": "module",
"ecmaVersion": 6,
"ecmaVersion": 2020,
},
"rules": {
"comma-dangle": [2, "always-multiline"],
2 changes: 1 addition & 1 deletion .github/FUNDING.yml
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@

github: [ljharb]
patreon: # Replace with a single Patreon username
open_collective: # Replace with a single Open Collective username
open_collective: eslint-plugin-import # Replace with a single Open Collective username
ko_fi: # Replace with a single Ko-fi username
tidelift: npm/eslint-plugin-import
community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
7 changes: 6 additions & 1 deletion .github/workflows/node-4+.yml
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@ jobs:
with:
versionsAsRoot: true
type: majors
preset: '>= 6' # preset: '>=4' # see https://github.com/benmosher/eslint-plugin-import/issues/2053
preset: '>= 6' # preset: '>=4' # see https://github.com/import-js/eslint-plugin-import/issues/2053

latest:
needs: [matrix]
@@ -33,6 +33,11 @@ jobs:
- 3
- 2
include:
- node-version: 'lts/*'
eslint: 7
ts-parser: 3
env:
TS_PARSER: 3
- node-version: 'lts/*'
eslint: 7
ts-parser: 2
2 changes: 1 addition & 1 deletion .github/workflows/packages.yml
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ jobs:
id: set-matrix
with:
type: 'majors'
preset: '>= 6' # preset: '>=4' # see https://github.com/benmosher/eslint-plugin-import/issues/2053
preset: '>= 6' # preset: '>=4' # see https://github.com/import-js/eslint-plugin-import/issues/2053
versionsAsRoot: true

tests:
Loading