remove server header

fixes #591
http-party · Aug 5, 2021 · a7fdf0f · a7fdf0f
1 parent 9c51cb2
commit a7fdf0f
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 58 deletions.
diff --git a/lib/core/aliases.json b/lib/core/aliases.json
@@ -8,7 +8,6 @@
   "handleError": [ "handleError", "handleerror" ],
   "cors": [ "cors", "CORS" ],
   "headers": [ "H", "header", "headers" ],
-  "serverHeader": [ "serverHeader", "serverheader", "server-header" ],
   "contentType": [ "contentType", "contenttype", "content-type" ],
   "mimeType": [
     "mimetype",

diff --git a/lib/core/defaults.json b/lib/core/defaults.json
@@ -11,7 +11,6 @@
   "brotli": false,
   "defaultExt": ".html",
   "handleError": true,
-  "serverHeader": true,
   "contentType": "application/octet-stream",
   "weakEtags": true,
   "weakCompare": true,

diff --git a/lib/core/index.js b/lib/core/index.js
@@ -101,7 +101,6 @@ module.exports = function createMiddleware(_dir, _options) {
   let defaultExt = opts.defaultExt;
   const handleError = opts.handleError;
   const headers = opts.headers;
-  const serverHeader = opts.serverHeader;
   const weakEtags = opts.weakEtags;
   const handleOptionsMethod = opts.handleOptionsMethod;
 
@@ -196,11 +195,6 @@ module.exports = function createMiddleware(_dir, _options) {
     gzippedFile = `${file}.gz`;
     brotliFile = `${file}.br`;
 
-    if (serverHeader !== false) {
-      // Set common headers.
-      res.setHeader('server', `http-server-${version}`);
-    }
-
     Object.keys(headers).forEach((key) => {
       res.setHeader(key, headers[key]);
     });

diff --git a/lib/core/opts.js b/lib/core/opts.js
@@ -18,7 +18,6 @@ module.exports = (opts) => {
   let defaultExt = defaults.defaultExt;
   let handleError = defaults.handleError;
   const headers = {};
-  let serverHeader = defaults.serverHeader;
   let contentType = defaults.contentType;
   let mimeTypes;
   let weakEtags = defaults.weakEtags;
@@ -140,14 +139,6 @@ module.exports = (opts) => {
       }
     });
 
-    aliases.serverHeader.some((k) => {
-      if (isDeclared(k)) {
-        serverHeader = opts[k];
-        return true;
-      }
-      return false;
-    });
-
     aliases.contentType.some((k) => {
       if (isDeclared(k)) {
         contentType = opts[k];
@@ -203,7 +194,6 @@ module.exports = (opts) => {
     brotli,
     handleError,
     headers,
-    serverHeader,
     contentType,
     mimeTypes,
     weakEtags,

diff --git a/test/server-header.test.js b/test/server-header.test.js