Skip to content

Commit 454851c

Browse files
committedApr 9, 2020
Fix security issue by using Minimist directly.
1 parent ed8ff1f commit 454851c

File tree

3 files changed

+5
-29
lines changed

3 files changed

+5
-29
lines changed
 

‎bin/http-server

+1-4
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,7 @@ var colors = require('colors/safe'),
88
portfinder = require('portfinder'),
99
opener = require('opener'),
1010
fs = require('fs'),
11-
argv = require('optimist')
12-
.boolean('cors')
13-
.boolean('log-ip')
14-
.argv;
11+
argv = require('minimist')(process.argv.slice(2));
1512
var ifaces = os.networkInterfaces();
1613

1714
process.title = 'http-server';

‎package-lock.json

+3-24
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@
8484
"corser": "^2.0.1",
8585
"ecstatic": "^3.3.2",
8686
"http-proxy": "^1.17.0",
87+
"minimist": "^1.2.5",
8788
"opener": "^1.5.1",
88-
"optimist": "~0.6.1",
8989
"portfinder": "^1.0.20",
9090
"secure-compare": "3.0.1",
9191
"union": "~0.5.0"

0 commit comments

Comments
 (0)
Please sign in to comment.