Support symbol properties for reach(). Closes #267

Author: kanongil

lib/index.js

@@ -486,13 +486,21 @@ exports.reach = function (obj, chain, options) {
         options = { separator: options };
     }
 
-    const path = chain.split(options.separator || '.');
+    const isChainArray = Array.isArray(chain);
+
+    exports.assert(!isChainArray || !options.separator, 'Separator option no valid for array-based chain');
+
+    const path = isChainArray ? chain : chain.split(options.separator || '.');
     let ref = obj;
     for (let i = 0; i < path.length; ++i) {
         let key = path[i];
-        if (key[0] === '-' && Array.isArray(ref)) {
-            key = key.slice(1, key.length);
-            key = ref.length - key;
+
+        if (Array.isArray(ref)) {
+            const number = Number(key);
+
+            if (Number.isInteger(number) && number < 0) {
+                key = ref.length + number;
+            }
         }
 
         if (!ref ||

test/index.js

@@ -1780,6 +1780,7 @@ describe('flatten()', () => {
 
 describe('reach()', () => {
 
+    const sym = Symbol();
     const obj = {
         a: {
             b: {
@@ -1792,7 +1793,10 @@ describe('reach()', () => {
             g: {
                 h: 3
             },
-            '-2': true
+            '-2': true,
+            [sym]: {
+                v: true
+            }
         },
         i: function () { },
         j: null,
@@ -1806,15 +1810,18 @@ describe('reach()', () => {
         expect(Hoek.reach(obj, null)).to.equal(obj);
         expect(Hoek.reach(obj, false)).to.equal(obj);
         expect(Hoek.reach(obj)).to.equal(obj);
+        expect(Hoek.reach(obj, [])).to.equal(obj);
     });
 
-    it('returns first value of array', () => {
+    it('returns values of array', () => {
 
         expect(Hoek.reach(obj, 'k.0')).to.equal(4);
+        expect(Hoek.reach(obj, 'k.1')).to.equal(8);
     });
 
     it('returns last value of array using negative index', () => {
 
+        expect(Hoek.reach(obj, 'k.-1')).to.equal(1);
         expect(Hoek.reach(obj, 'k.-2')).to.equal(9);
     });
 
@@ -1860,6 +1867,9 @@ describe('reach()', () => {
     it('returns undefined on invalid member', () => {
 
         expect(Hoek.reach(obj, 'a.b.c.d-.x')).to.equal(undefined);
+        expect(Hoek.reach(obj, 'k.x')).to.equal(undefined);
+        expect(Hoek.reach(obj, 'k.1000')).to.equal(undefined);
+        expect(Hoek.reach(obj, 'k/0.5', '/')).to.equal(undefined);
     });
 
     it('returns function member', () => {
@@ -1899,6 +1909,21 @@ describe('reach()', () => {
 
         expect(Hoek.reach(obj, 'q', { default: '' })).to.equal('');
     });
+
+    it('allows array-based lookup', () => {
+
+        expect(Hoek.reach(obj, ['a', 'b', 'c', 'd'])).to.equal(1);
+        expect(Hoek.reach(obj, ['k', '1'])).to.equal(8);
+        expect(Hoek.reach(obj, ['k', 1])).to.equal(8);
+        expect(Hoek.reach(obj, ['k', '-2'])).to.equal(9);
+        expect(Hoek.reach(obj, ['k', -2])).to.equal(9);
+    });
+
+    it('allows array-based lookup with symbols', () => {
+
+        expect(Hoek.reach(obj, ['a', sym, 'v'])).to.equal(true);
+        expect(Hoek.reach(obj, ['a', Symbol(), 'v'])).to.equal(undefined);
+    });
 });
 
 describe('reachTemplate()', () => {