fix: Do not override existing json diagnostic schemas (#3523)

graphql · Feb 1, 2024 · 88d76ca · 88d76ca
1 parent 25c3bfd
commit 88d76ca
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/.changeset/healthy-toes-grab.md b/.changeset/healthy-toes-grab.md
@@ -0,0 +1,5 @@
+---
+'monaco-graphql': patch
+---
+
+Fix JSON diagnostics for multiple editors
diff --git a/packages/monaco-graphql/src/languageFeatures.ts b/packages/monaco-graphql/src/languageFeatures.ts
@@ -150,12 +150,17 @@ export class DiagnosticsAdapter {
         schema: jsonSchema,
         fileMatch: variablesUris,
       };
+      const currentSchemas =
+        languages.json.jsonDefaults.diagnosticsOptions.schemas?.filter(
+          s => s.uri !== schemaUri,
+        ) || [];
+
       // TODO: export from api somehow?
       languages.json.jsonDefaults.setDiagnosticsOptions({
         schemaValidation: 'error',
         validate: true,
         ...this.defaults?.diagnosticSettings?.jsonDiagnosticSettings,
-        schemas: [configResult],
+        schemas: [...currentSchemas, configResult],
         enableSchemaRequest: false,
       });
     }