fix: re-enable lint step in CircleCI (#252)

Author: JustinBeckwith

.circleci/config.yml

@@ -12,22 +12,22 @@ workflows:
       - node10:
           filters: *all_commits
       - docs:
-          requires:
-            - node6
-            - node8
-            - node10
+          filters: *all_commits
+      - lint:
           filters: *all_commits
       - system_tests:
-          requires:
-            - docs
           filters:
             branches:
               only: master
             tags: &releases
               only: '/^v[\d.]+$/'
       - publish_npm:
           requires:
+            - node6
+            - node8
+            - node10
             - system_tests
+            - docs
           filters:
             branches:
               ignore: /.*/
@@ -65,8 +65,8 @@ jobs:
             npm install
           environment:
             NPM_CONFIG_PREFIX: /home/node/.npm-global
-      - run: npm test
-      - run: node_modules/.bin/codecov
+      - run: npm run test-only
+      - run: npm run codecov
   node8:
     docker:
       - image: 'node:8'
@@ -77,6 +77,14 @@ jobs:
       - image: 'node:10'
         user: node
     steps: *unit_tests_steps
+  lint:
+    docker:
+      - image: 'node:10'
+        user: node
+    steps:
+      - checkout
+      - run: *npm_install_and_link
+      - run: npm run check
   docs:
     docker:
       - image: 'node:10'
@@ -85,9 +93,7 @@ jobs:
       - checkout
       - run: *remove_package_lock
       - run: *npm_install_and_link
-      - run:
-          name: Build documentation.
-          command: npm run docs
+      - run: npm run docs
   system_tests:
     docker:
       - image: 'node:10'
@@ -120,5 +126,5 @@ jobs:
         user: node
     steps:
       - checkout
-      - run: 'echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc'
+      - run: echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc
       - run: npm publish

.gitignore

@@ -7,3 +7,4 @@ out/
 system-test/secrets.js
 system-test/*key.json
 *.lock
+build/

package-lock.json

@@ -36,20 +36,19 @@
     "greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>"
   ],
   "scripts": {
-    "cover": "nyc --reporter=lcov mocha --require intelli-espower-loader build/test/*.js && nyc report",
+    "codecov": "nyc report --reporter=json && codecov -f .coverage/*.json",
     "docs": "jsdoc -c .jsdoc.js",
     "generate-scaffolding": "repo-tools generate all",
-    "publish-module": "node ../../scripts/publish.js firestore",
-    "system-test": "mocha build/system-test/*.js --timeout 600000",
-    "conformance": "mocha build/conformance/*.js --timeout 2000",
-    "test-no-cover": "mocha build/test/*.js --timeout 2000",
-    "test": "npm run cover",
+    "system-test": "mocha build/system-test --timeout 600000",
+    "conformance": "mocha build/conformance",
+    "test-only": "nyc mocha build/test",
+    "test": "npm run test-only",
     "check": "gts check",
     "clean": "gts clean",
     "compile": "tsc -p . && cp -r protos build/protos && cp -r test/fake-certificate.json build/test/fake-certificate.json  && cp src/v1beta1/firestore_client_config.json build/src/v1beta1/ && cp conformance/test-definition.proto build/conformance && cp conformance/test-suite.binproto build/conformance",
     "fix": "gts fix",
     "prepare": "npm run compile",
-    "pretest": "npm run compile",
+    "pretest-only": "npm run compile",
     "posttest": "npm run check"
   },
   "dependencies": {
@@ -70,6 +69,8 @@
     "@types/node": "^10.3.5",
     "codecov": "^3.0.2",
     "duplexify": "^3.6.0",
+    "gts": "^0.7.1",
+    "hard-rejection": "^1.0.0",
     "ink-docstrap": "git+https://github.com/docstrap/docstrap.git",
     "intelli-espower-loader": "^1.0.1",
     "jsdoc": "^3.5.5",
@@ -78,7 +79,7 @@
     "power-assert": "^1.6.0",
     "protobufjs": "^6.8.6",
     "proxyquire": "^2.0.1",
-    "typescript": "^2.9.2",
-    "gts": "^0.7.1"
+    "source-map-support": "^0.5.6",
+    "typescript": "^2.9.2"
   }
 }

package.json

@@ -0,0 +1,4 @@
+--require hard-rejection/register
+--require source-map-support/register
+--require intelli-espower-loader
+--timeout 2000