Removing assert that fails the system-tests on CI (#260)

googleapis · Jul 13, 2018 · 41832eb · 41832eb
1 parent f01d512
commit 41832eb
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 16 deletions.
diff --git a/src/index.js b/src/index.js
@@ -455,11 +455,7 @@ class Firestore {
    * for existing documents, otherwise a DocumentSnapshot.
    */
   snapshot_(documentOrName, readTime, encoding) {
-    if (!this._initalizationSettings.projectId) {
-      throw new Error(
-          'Cannot use `snapshot_()` without a Project ID. Please provide a ' +
-          'Project ID via `Firestore.settings()`.');
-    }
+    // TODO: Assert that Firestore Project ID is valid.
 
     let convertTimestamp;
     let convertDocument;

diff --git a/test/index.js b/test/index.js
@@ -540,17 +540,6 @@ describe('snapshot_() method', function() {
     });
   });
 
-  it('validates Project ID provided', function() {
-    firestore = new Firestore({
-      sslCreds: grpc.credentials.createInsecure(),
-      keyFilename: './test/fake-certificate.json'
-    });
-
-    assert.throws(
-        () => firestore.snapshot_(),
-        /Cannot use `snapshot_\(\)` without a Project ID. Please provide a Project ID via `Firestore.settings\(\)`./);
-  });
-
   it('handles ProtobufJS', function() {
     let doc = firestore.snapshot_(
         document('doc', {