ref(node): Add source code context from LinkedErrors so integration order doesn't matter #4753
+37
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
force-pushed
the
fix/linked-error-context-lines
branch
from
6b89be4 to
31a1392
Compare
AbhiPrasad
reviewed
Mar 23, 2022
| @@ -199,11 +199,11 @@ describe('SentryNode', () => { | |||
| } | |||
| }); | |||
|
|
|||
| test.only('capture a linked exception with pre/post context', done => { | |||
| test('capture a linked exception with pre/post context', done => { | |||
AbhiPrasad
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4729
@AbhiPrasad This is an alternative that gets this working for now without ordered integrations.
This PR:
ContextLinesintegration so it can be used from elsewhere with it's optionsLinkedErrorsintegration, if theContextLinesintegration is enabled, adds context to linked errorsAlso noticed that I left one of the tests with
onlyenabled!