feat(nextjs): Add option to use hidden-source-map as webpack devtool value
#4436
+29
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobsterkatie
force-pushed
the
kmclb-nextjs-allow-hidden-sourcemaps
branch
from
13a2050 to
cf6643b
Compare
size-limit report
|
kamilogorek
reviewed
Jan 24, 2022
kamilogorek
approved these changes
Jan 24, 2022
lobsterkatie
force-pushed
the
kmclb-nextjs-allow-hidden-sourcemaps
branch
from
cf6643b to
6fe684b
Compare
lobsterkatie
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Jan 24, 2022
This documents the option added in getsentry/sentry-javascript#4436, to allow users to use `hidden-source-map` as their webpack `devtool` for client-side builds. (With this option enabled, the same sourcemaps are generated, but the final bundles don't have a `sourceMappingURL` comment, effectively "hiding" the sourcemaps from the browser. Doing this prevents the browser from complaining in situations where the maps are not publicly hosted.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently force the value of the webpack option
devtoolto besource-map, in order to guarantee that the correct sourcemaps are generated during build. There is anotherdevtoolvalue,hidden-source-map, which produces the same maps (so just as good for our purposes), but without addingsourceMappingURLcomments at the bottom of the resulting JS files. (Some users prefer this as a way not to have the browser complain when it tries to follow thesourceMappingURLlink and comes up empty.)This PR adds an option that users can pass in their nextjs config, under the key
sentry.hideSourceMaps. When this is set to true, the SDK will usehidden-source-mapas thedevtoolvalue instead ofsource-map. Note that since this is a front-end-only problem, the option only applies to client-side builds.The new option is documented in getsentry/sentry-docs#4627.
Fixes #3549.