feat(react): Add reactRouterV6BrowserTracingIntegration for react router v6 & v6.4
#10491
+1,707
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Feb 5, 2024
packages/react/src/index.ts
Outdated
| reactRouterV6Instrumentation, | ||
| browserTracingReactRouterV6Integration, |
There was a problem hiding this comment.
Same as in #10489, I think it would be cleaner to call it reactRouterV6BrowserTracingIntegration.
feat(react): Add browserTracingIntegrations for router v4 & v5 This adds a new `browserTracingReactRouterV6Integration()` exports deprecating the old routing instrumentation. I opted to leave as much as possible as-is for now, except for streamlining the attributes/tags we use for the instrumentation.
mydea
force-pushed
the
fn/react-router-v6
branch
from
204ed88 to
a37f678
Compare
mydea
changed the title
browserTracingIntegration for react router v6 & v6.4reactRouterV6BrowserTracingIntegration for react router v6 & v6.4
AbhiPrasad
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(react): Add browserTracingIntegrations for router v4 & v5
This adds a new
reactRouterV6BrowserTracingIntegration()exports deprecating the old routing instrumentation.I opted to leave as much as possible as-is for now, except for streamlining the attributes/tags we use for the instrumentation.
I also updated the E2E tests to the new format.