Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feedback): Fix logo color when colorScheme is "system" #10465

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Feb 1, 2024

The CSS when colorScheme is "system" was always being overwritten so the logo color ends up being incorrect when OS is in dark mode.

image

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
The CSS when colorScheme is "system" was always being overwritten so the logo color ends up being incorrect when OS is in dark mode.
Copy link
Contributor

github-actions bot commented Feb 1, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.14 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.38 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.3 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.99 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.38 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.25 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.33 KB (+0.02% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.34 KB (+0.02% 🔺)
@sentry/browser - Webpack (gzipped) 22.6 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.11 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.66 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.5 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.66 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 213.5 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.49 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74.01 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.63 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.73 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped) 22.63 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.5 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.8 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (+0.03% 🔺)

@billyvg billyvg marked this pull request as ready for review February 1, 2024 18:54
@billyvg billyvg requested a review from a team February 1, 2024 18:54
@billyvg billyvg merged commit a489dbf into develop Feb 1, 2024
@billyvg billyvg deleted the fix-feedback-fix-dark-theme-logo branch February 1, 2024 20:26
onurtemizkan pushed a commit that referenced this pull request Feb 4, 2024
The CSS when colorScheme is "system" was always being overwritten so the
logo color ends up being incorrect when OS is in dark mode.


![image](https://github.com/getsentry/sentry-javascript/assets/79684/062b3e1d-d310-470c-93f0-53105cfb89de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants