Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nextjs): Add browserTracingIntegration #10397

Merged
merged 13 commits into from
Feb 2, 2024
Merged

feat(nextjs): Add browserTracingIntegration #10397

merged 13 commits into from
Feb 2, 2024
+297 −105

Conversation

lforst
Copy link
Member

@lforst lforst commented Jan 29, 2024 •
edited
Loading

Adds a wrapped browserTracingIntegration export to the Next.js package that transparently reuses the existing routing instrumentation.

Also deprecates the old BrowserTracing integration.

Ref #10387

lforst added 4 commits January 29, 2024 17:00
@lforst
feat(nextjs): Add browserTracingIntegration
7d3a193
@lforst
Merge remote-tracking branch 'origin/develop' into lforst-nextjs-rout…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f4224f8 
…ing-instrumentation
@lforst
Merge remote-tracking branch 'origin/develop' into lforst-nextjs-rout…
1054a8c 
…ing-instrumentation
@lforst
Hmm
7393eed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.15 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.38 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.3 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.99 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.38 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.25 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.33 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.34 KB (0%)
@sentry/browser - Webpack (gzipped) 22.6 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.11 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.66 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.5 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.66 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 213.5 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.49 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74.01 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.63 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.73 KB (0%)
@sentry/react - Webpack (gzipped) 22.63 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.35 KB (+0.99% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 51.57 KB (+1.52% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)

@lforst lforst mentioned this pull request Jan 31, 2024
Closed
@lforst lforst marked this pull request as ready for review January 31, 2024 15:33
@lforst lforst requested review from mydea, Lms24 and AbhiPrasad January 31, 2024 15:33
mydea
mydea reviewed Feb 2, 2024
View reviewed changes
.github/workflows/build.yml Outdated
@@ -931,7 +931,7 @@ jobs:
github.actor != 'dependabot[bot]'
needs: [job_get_metadata, job_build, job_e2e_prepare]
runs-on: ubuntu-20.04
timeout-minutes: 10
timeout-minutes: 20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems a bit long, but 🤷

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. I'll try turning it back down.

@lforst lforst merged commit cfb1b60 into develop Feb 2, 2024
@lforst lforst deleted the lforst-nextjs-routing-instrumentation branch February 2, 2024 16:43
onurtemizkan pushed a commit that referenced this pull request Feb 4, 2024
@lforst @onurtemizkan
feat(nextjs): Add browserTracingIntegration (#10397)
fe096e8
@lforst lforst mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea

@Lms24 Lms24

@AbhiPrasad AbhiPrasad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lforst @mydea @Lms24 @AbhiPrasad