Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gajus/eslint-config-canonical
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3e46d435017429bbf83b1ca05721e5cd7d684a01
Choose a base ref
...
head repository: gajus/eslint-config-canonical
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 137fb17e18391b36f4437dc67095804632d5ff59
Choose a head ref

Commits on Apr 22, 2019

  1. feat: add new rules

    BREAKING CHANGE: new rules added
    gajus committed Apr 22, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    8ad329c View commit details

Commits on Apr 24, 2019

  1. Copy the full SHA
    7cb2d9c View commit details

Commits on May 15, 2019

  1. fix: allow args

    gajus committed May 15, 2019
    Copy the full SHA
    e83dfaa View commit details

Commits on May 16, 2019

  1. Copy the full SHA
    ea8d7ba View commit details

Commits on Jun 18, 2019

  1. docs: add gitspo mentions badge

    gajus committed Jun 18, 2019
    Copy the full SHA
    f2330a0 View commit details

Commits on Jun 19, 2019

  1. Create FUNDING.yml

    gajus authored Jun 19, 2019
    Copy the full SHA
    c9db68f View commit details

Commits on Jun 20, 2019

  1. Copy the full SHA
    d85ac0d View commit details
  2. Copy the full SHA
    22c1757 View commit details

Commits on Jun 28, 2019

  1. Copy the full SHA
    80cf729 View commit details
  2. Merge pull request #18 from brettz9/patch-1

    fix: update peerDeps to include ESLint 6.0
    gajus authored Jun 28, 2019
    Copy the full SHA
    d374d08 View commit details

Commits on Jul 10, 2019

  1. Copy the full SHA
    e1f87c4 View commit details
  2. Copy the full SHA
    180c5b9 View commit details
  3. fix: update dependencies

    gajus committed Jul 10, 2019
    Copy the full SHA
    ccb0032 View commit details

Commits on Jul 13, 2019

  1. fix: update comparison

    gajus committed Jul 13, 2019
    Copy the full SHA
    01d7a75 View commit details

Commits on Jul 25, 2019

  1. Copy the full SHA
    6af0291 View commit details
  2. Copy the full SHA
    5eb90e3 View commit details
  3. Copy the full SHA
    100be88 View commit details

Commits on Jul 27, 2019

  1. Copy the full SHA
    391b006 View commit details

Commits on Jul 28, 2019

  1. fix: update dependencies

    gajus committed Jul 28, 2019
    Copy the full SHA
    806fbea View commit details

Commits on Aug 3, 2019

  1. Copy the full SHA
    b973ea9 View commit details

Commits on Aug 8, 2019

  1. Copy the full SHA
    04e6b3c View commit details
  2. Copy the full SHA
    ad6b538 View commit details

Commits on Aug 26, 2019

  1. Copy the full SHA
    78ce018 View commit details

Commits on Sep 2, 2019

  1. feat: add exception for props

    gajus committed Sep 2, 2019
    Copy the full SHA
    2ab2511 View commit details
  2. Copy the full SHA
    aa75410 View commit details
  3. feat: add react-hooks

    gajus committed Sep 2, 2019
    Copy the full SHA
    bb181c4 View commit details

Commits on Nov 2, 2019

  1. Copy the full SHA
    956d2c9 View commit details

Commits on Nov 12, 2019

  1. feat: update dependencies and add new rules

    BREAKING CHANGE: adds new rules
    gajus committed Nov 12, 2019
    Copy the full SHA
    137fb17 View commit details
Showing with 186 additions and 105 deletions.
  1. +2 −0 .github/FUNDING.yml
  2. +74 −71 README.md
  3. +2 −0 compare/package.json
  4. +7 −6 configurations/ava.json
  5. +48 −7 configurations/eslintrc.json
  6. +16 −1 configurations/flowtype.json
  7. +2 −1 configurations/mocha.json
  8. +17 −2 configurations/react.json
  9. +18 −17 package.json
2 changes: 2 additions & 0 deletions .github/FUNDING.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
github: gajus
patreon: gajus
145 changes: 74 additions & 71 deletions README.md

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions compare/package.json
Original file line number Diff line number Diff line change
@@ -3,6 +3,8 @@
"eslint": "^5.6.1",
"eslint-config-airbnb": "^17.1.0",
"eslint-config-canonical": "^13.0.0",
"eslint-config-google": "^0.13.0",
"eslint-config-standard": "^13.0.1",
"eslint-plugin-jsx-a11y": "^6.1.1",
"eslint-plugin-node": "^7.0.1",
"eslint-plugin-standard": "^4.0.0"
13 changes: 7 additions & 6 deletions configurations/ava.json
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@
],
"rules": {
"ava/assertion-arguments": 2,
"ava/hooks-order": 2,
"ava/max-asserts": [
1,
5
@@ -13,7 +14,9 @@
"ava/no-duplicate-modifiers": 2,
"ava/no-identical-title": 2,
"ava/no-ignored-test-files": 2,
"ava/no-import-test-files": 2,
"ava/no-import-test-files": 0,
"ava/no-incorrect-deep-equal": 2,
"ava/no-inline-assertions": 2,
"ava/no-invalid-end": 2,
"ava/no-nested-tests": 2,
"ava/no-only-test": 2,
@@ -24,12 +27,10 @@
"ava/no-todo-test": 1,
"ava/no-unknown-modifiers": 2,
"ava/prefer-async-await": 2,
"ava/prefer-power-assert": 2,
"ava/prefer-power-assert": 0,
"ava/prefer-t-regex": 2,
"ava/test-ended": 2,
"ava/test-title": [
2,
"if-multiple"
],
"ava/test-title": 2,
"ava/use-t": 2,
"ava/use-t-well": 2,
"ava/use-test": 2,
55 changes: 48 additions & 7 deletions configurations/eslintrc.json
Original file line number Diff line number Diff line change
@@ -74,7 +74,7 @@
"class-methods-use-this": 2,
"comma-dangle": [
2,
"never"
"always-multiline"
],
"comma-spacing": [
2,
@@ -118,7 +118,6 @@
],
"filenames/no-index": 0,
"for-direction": 2,
"fp/no-unused-expression": 0,
"fp/no-arguments": 2,
"fp/no-class": 2,
"fp/no-delete": 2,
@@ -134,6 +133,7 @@
"fp/no-rest-parameters": 0,
"fp/no-this": 2,
"fp/no-throw": 0,
"fp/no-unused-expression": 0,
"fp/no-valueof-field": 2,
"func-call-spacing": [
2,
@@ -220,7 +220,7 @@
"import/no-cycle": 2,
"import/no-default-export": 0,
"import/no-deprecated": 1,
"import/no-duplicates": 0,
"import/no-duplicates": 2,
"import/no-dynamic-require": 2,
"import/no-extraneous-dependencies": [
2,
@@ -235,6 +235,7 @@
"import/no-named-as-default": 2,
"import/no-named-as-default-member": 2,
"import/no-named-default": 2,
"import/no-named-export": 0,
"import/no-namespace": 2,
"import/no-nodejs-modules": 0,
"import/no-relative-parent-imports": 0,
@@ -258,7 +259,7 @@
"newlines-between": "never"
}
],
"import/prefer-default-export": 1,
"import/prefer-default-export": 0,
"import/unambiguous": 1,
"indent": [
2,
@@ -374,7 +375,7 @@
"no-console": 2,
"no-const-assign": 2,
"no-constant-condition": 1,
"no-continue": 2,
"no-continue": 0,
"no-control-regex": 2,
"no-debugger": 1,
"no-delete-var": 2,
@@ -383,7 +384,7 @@
"no-dupe-class-members": 2,
"no-dupe-keys": 2,
"no-duplicate-case": 2,
"no-duplicate-imports": 2,
"no-duplicate-imports": 0,
"no-else-return": 0,
"no-empty": 2,
"no-empty-character-class": 2,
@@ -500,6 +501,7 @@
"no-use-before-define": 2,
"no-use-extend-native/no-use-extend-native": 2,
"no-useless-call": 2,
"no-useless-catch": 2,
"no-useless-computed-key": 2,
"no-useless-concat": 2,
"no-useless-constructor": 2,
@@ -566,6 +568,7 @@
"prefer-arrow-callback": 2,
"prefer-const": 2,
"prefer-destructuring": 0,
"prefer-named-capture-group": 0,
"prefer-numeric-literals": 2,
"prefer-promise-reject-errors": 2,
"prefer-reflect": 0,
@@ -672,24 +675,62 @@
"name": "error"
}
],
"unicorn/consistent-function-scoping": 1,
"unicorn/custom-error-definition": 0,
"unicorn/error-message": 2,
"unicorn/expiring-todo-comments": [
2,
{
"allowWarningComments": true,
"ignoreDatesOnPullRequests": true,
"terms": [
"todo"
]
}
],
"unicorn/explicit-length-check": 0,
"unicorn/filename-case": 0,
"unicorn/import-index": 2,
"unicorn/new-for-builtins": 2,
"unicorn/no-abusive-eslint-disable": 2,
"unicorn/no-array-instanceof": 2,
"unicorn/no-console-spaces": 0,
"unicorn/no-fn-reference-in-iterator": 0,
"unicorn/no-for-loop": 2,
"unicorn/no-hex-escape": 2,
"unicorn/no-nested-ternary": 0,
"unicorn/no-new-buffer": 2,
"unicorn/no-process-exit": 0,
"unicorn/no-unreadable-array-destructuring": 0,
"unicorn/no-unused-properties": 1,
"unicorn/no-zero-fractions": 2,
"unicorn/number-literal-case": 2,
"unicorn/prefer-add-event-listener": 0,
"unicorn/prefer-dataset": 2,
"unicorn/prefer-event-key": 2,
"unicorn/prefer-exponentiation-operator": 2,
"unicorn/prefer-flat-map": 2,
"unicorn/prefer-includes": 2,
"unicorn/prefer-node-append": 2,
"unicorn/prefer-node-remove": 2,
"unicorn/prefer-query-selector": 2,
"unicorn/prefer-reflect-apply": 2,
"unicorn/prefer-spread": 0,
"unicorn/prefer-starts-ends-with": 2,
"unicorn/prefer-string-slice": 2,
"unicorn/prefer-text-content": 2,
"unicorn/prefer-type-error": 2,
"unicorn/prevent-abbreviations": [
2,
{
"replacements": {
"args": false,
"props": false,
"ref": false,
"rel": false
}
}
],
"unicorn/regex-shorthand": 2,
"unicorn/throw-new-error": 2,
"use-isnan": 2,
@@ -707,4 +748,4 @@
".js"
]
}
}
}
17 changes: 16 additions & 1 deletion configurations/flowtype.json
Original file line number Diff line number Diff line change
@@ -3,14 +3,18 @@
"flowtype"
],
"rules": {
"flowtype/arrow-parens": [
2,
"always"
],
"flowtype/boolean-style": [
2,
"boolean"
],
"flowtype/define-flow-type": 1,
"flowtype/delimiter-dangle": [
2,
"never"
"always-multiline"
],
"flowtype/generic-spacing": [
2,
@@ -19,6 +23,7 @@
"flowtype/newline-after-flow-annotation": 2,
"flowtype/no-existential-type": 0,
"flowtype/no-flow-fix-me-comments": 1,
"flowtype/no-mixed": 2,
"flowtype/no-mutable-array": 2,
"flowtype/no-primitive-constructor-types": 2,
"flowtype/no-types-missing-file-annotation": 2,
@@ -30,7 +35,16 @@
],
"flowtype/require-compound-type-alias": 1,
"flowtype/require-exact-type": 1,
"flowtype/require-indexer-name": [
2,
"never"
],
"flowtype/require-inexact-type": [
2,
"always"
],
"flowtype/require-parameter-type": 0,
"flowtype/require-readonly-react-props": 2,
"flowtype/require-return-type": 0,
"flowtype/require-types-at-top": 2,
"flowtype/require-valid-file-annotation": 2,
@@ -59,6 +73,7 @@
2,
"never"
],
"flowtype/spread-exact-type": 0,
"flowtype/type-id-match": [
2,
"^([A-Z][a-z0-9]+)+Type$"
3 changes: 2 additions & 1 deletion configurations/mocha.json
Original file line number Diff line number Diff line change
@@ -14,10 +14,11 @@
],
"mocha/no-exclusive-tests": 2,
"mocha/no-hooks-for-single-case": 1,
"mocha/no-setup-in-describe": 2,
"mocha/no-identical-title": 2,
"mocha/no-nested-tests": 2,
"mocha/no-return-and-callback": 2,
"mocha/no-return-from-async": 2,
"mocha/no-setup-in-describe": 2,
"mocha/no-top-level-hooks": 2
}
}
19 changes: 17 additions & 2 deletions configurations/react.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
{
"plugins": [
"react"
"react",
"react-hooks"
],
"rules": {
"react-hooks/exhaustive-deps": 1,
"react-hooks/rules-of-hooks": 2,
"react/boolean-prop-naming": 0,
"react/button-has-type": 2,
"react/default-props-match-prop-types": 2,
@@ -21,6 +24,7 @@
"react/jsx-closing-bracket-location": 0,
"react/jsx-closing-tag-location": 0,
"react/jsx-curly-brace-presence": 0,
"react/jsx-curly-newline": 2,
"react/jsx-curly-spacing": [
2,
"never",
@@ -36,6 +40,10 @@
2,
"multiline-multiprop"
],
"react/jsx-fragments": [
2,
"syntax"
],
"react/jsx-handler-names": [
2,
{
@@ -72,9 +80,10 @@
"react/jsx-no-literals": 0,
"react/jsx-no-target-blank": 2,
"react/jsx-no-undef": 2,
"react/jsx-one-expression-per-line": 2,
"react/jsx-one-expression-per-line": 0,
"react/jsx-pascal-case": 2,
"react/jsx-props-no-multi-spaces": 2,
"react/jsx-props-no-spreading": 0,
"react/jsx-sort-default-props": 2,
"react/jsx-sort-props": 2,
"react/jsx-tag-spacing": [
@@ -112,6 +121,7 @@
"react/no-unused-state": 2,
"react/no-will-update-set-state": 2,
"react/prefer-es6-class": 2,
"react/prefer-read-only-props": 1,
"react/prefer-stateless-function": [
2,
{
@@ -125,6 +135,11 @@
"react/self-closing-comp": 2,
"react/sort-comp": 2,
"react/sort-prop-types": 2,
"react/state-in-constructor": [
2,
"always"
],
"react/static-property-placement": 2,
"react/style-prop-object": 2,
"react/void-dom-elements-no-children": 2
}
35 changes: 18 additions & 17 deletions package.json
Original file line number Diff line number Diff line change
@@ -6,30 +6,31 @@
},
"ava": {},
"dependencies": {
"babel-eslint": "^10.0.1",
"eslint-plugin-ava": "^5.1.1",
"babel-eslint": "^10.0.3",
"eslint-plugin-ava": "^9.0.0",
"eslint-plugin-babel": "^5.3.0",
"eslint-plugin-filenames": "^1.3.2",
"eslint-plugin-flowtype": "^3.2.0",
"eslint-plugin-flowtype": "^4.3.0",
"eslint-plugin-fp": "^2.3.0",
"eslint-plugin-import": "^2.14.0",
"eslint-plugin-jest": "^22.1.2",
"eslint-plugin-jsdoc": "^3.9.1",
"eslint-plugin-lodash": "^5.1.0",
"eslint-plugin-mocha": "^5.2.0",
"eslint-plugin-no-use-extend-native": "^0.3.12",
"eslint-plugin-promise": "^4.0.1",
"eslint-plugin-react": "^7.11.1",
"eslint-plugin-import": "^2.18.2",
"eslint-plugin-jest": "^23.0.3",
"eslint-plugin-jsdoc": "^17.1.2",
"eslint-plugin-lodash": "^6.0.0",
"eslint-plugin-mocha": "^6.2.1",
"eslint-plugin-no-use-extend-native": "^0.4.1",
"eslint-plugin-promise": "^4.2.1",
"eslint-plugin-react": "^7.16.0",
"eslint-plugin-react-hooks": "^2.2.0",
"eslint-plugin-sort-keys-fix": "^1.0.1",
"eslint-plugin-unicorn": "^6.0.1"
"eslint-plugin-unicorn": "^12.1.0"
},
"description": "Canonical ESLint Shareable Config",
"devDependencies": {
"ava": "^1.0.0-beta.8",
"eslint": "^5.9.0",
"husky": "^1.2.0",
"ava": "^2.4.0",
"eslint": "^5.16.0",
"husky": "^3.0.9",
"jsonlint": "^1.6.3",
"semantic-release": "^15.12.4"
"semantic-release": "^15.13.30"
},
"husky": {
"hooks": {
@@ -44,7 +45,7 @@
"main": "./eslintrc.js",
"name": "eslint-config-canonical",
"peerDependencies": {
"eslint": "^5.9.0"
"eslint": "^6.6.0"
},
"repository": {
"type": "git",