Skip to content

Commit ccab9b7

Browse files
authoredMar 26, 2024··
Add Service Usage Consumer role to GitHub Actions service account (#6895)
* Add Service Usage Consumer role to GitHub Actions service account * Added a changelog entry
1 parent 4c1bd42 commit ccab9b7

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed
 

‎CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1+
- Fixes issue where GitHub actions service account cannot add preview URLs to Auth authorized domains (#6895)
12
- Release Firestore Emulator 1.19.4. This version fixes a minor bug with reserve ids and adds a `reset` endpoint for Datastore Mode.

‎src/gcp/resourceManager.ts

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export const firebaseRoles = {
1414
functionsDeveloper: "roles/cloudfunctions.developer",
1515
hostingAdmin: "roles/firebasehosting.admin",
1616
runViewer: "roles/run.viewer",
17+
serviceUsageConsumer: "roles/serviceusage.serviceUsageConsumer",
1718
};
1819

1920
/**

‎src/init/features/hosting/github.ts

+4
Original file line numberDiff line numberDiff line change
@@ -611,6 +611,10 @@ async function createServiceAccountAndKey(
611611
// https://github.com/firebase/firebase-tools/issues/2732
612612
firebaseRoles.authAdmin,
613613

614+
// Required to add preview URLs to Auth authorized domains
615+
// https://github.com/firebase/firebase-tools/issues/6828
616+
firebaseRoles.serviceUsageConsumer,
617+
614618
// Required for CLI deploys
615619
firebaseRoles.apiKeysViewer,
616620

0 commit comments

Comments
 (0)
Please sign in to comment.