chore: more perf (#5016)

* chore: genId perf optimization

* chore: perf syntax

* chore: perf syntax reply

* chore: Update lib/reply.js

Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>

* rollback

---------

Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>

Author: Eomm

lib/reply.js

@@ -244,7 +244,7 @@ Reply.prototype.header = function (key, value = '') {
     }
 
     if (Array.isArray(value)) {
-      this[kReplyHeaders][key].push(...value)
+      Array.prototype.push.apply(this[kReplyHeaders][key], value)
     } else {
       this[kReplyHeaders][key].push(value)
     }
@@ -810,7 +810,7 @@ function onResponseCallback (err, request, reply) {
 }
 
 function buildReply (R) {
-  const props = [...R.props]
+  const props = R.props.slice()
 
   function _Reply (res, request, log) {
     this.raw = res

lib/reqIdGenFactory.js

@@ -12,6 +12,16 @@
  * @returns {GenerateRequestId}
  */
 function reqIdGenFactory (requestIdHeader, optGenReqId) {
+  const genReqId = optGenReqId || buildDefaultGenReqId()
+
+  if (requestIdHeader) {
+    return buildOptionalHeaderReqId(requestIdHeader, genReqId)
+  }
+
+  return genReqId
+}
+
+function buildDefaultGenReqId () {
   // 2,147,483,647 (2^31 − 1) stands for max SMI value (an internal optimization of V8).
   // With this upper bound, if you'll be generating 1k ids/sec, you're going to hit it in ~25 days.
   // This is very likely to happen in real-world applications, hence the limit is enforced.
@@ -20,20 +30,16 @@ function reqIdGenFactory (requestIdHeader, optGenReqId) {
   const maxInt = 2147483647
 
   let nextReqId = 0
-  function defaultGenReqId (_req) {
+  return function defaultGenReqId () {
     nextReqId = (nextReqId + 1) & maxInt
     return `req-${nextReqId.toString(36)}`
   }
+}
 
-  const genReqId = optGenReqId || defaultGenReqId
-
-  if (requestIdHeader) {
-    return function (req) {
-      return req.headers[requestIdHeader] || genReqId(req)
-    }
+function buildOptionalHeaderReqId (requestIdHeader, genReqId) {
+  return function (req) {
+    return req.headers[requestIdHeader] || genReqId(req)
   }
-
-  return genReqId
 }
 
 module.exports = {

lib/request.js

@@ -66,7 +66,7 @@ function buildRequest (R, trustProxy) {
 }
 
 function buildRegularRequest (R) {
-  const props = [...R.props]
+  const props = R.props.slice()
   function _Request (id, params, req, query, log, context) {
     this.id = id
     this[kRouteContext] = context