Don't minify symbols in production builds (#28881)

This disables symbol renaming in production builds. The original
variable and function names are preserved. All other forms of
compression applied by Closure (dead code elimination, inlining, etc)
are unchanged — the final program is identical to what we were producing
before, just in a more readable form.

The motivation is to make it easier to debug React issues that only
occur in production — the same reason we decided to start shipping
sourcemaps in #28827 and #28827.

However, because most apps run their own minification step on their npm
dependencies, it's not necessary for us to minify the symbols before
publishing — it'll be handled the app, if desired.

This is the same strategy Meta has used to ship React for years. The
React build itself has unminified symbols, but they get minified as part
of Meta's regular build pipeline.

Even if an app does not minify their npm dependencies, gzip covers most
of the cost of symbol renaming anyway.

This saves us from having to ship sourcemaps, which means even apps that
don't have sourcemaps configured will be able to debug the React build
as easily as they would any other npm dependency.

Author: acdlite

dangerfile.js

@@ -43,8 +43,8 @@ const SIGNIFICANCE_THRESHOLD = 0.002;
 const CRITICAL_ARTIFACT_PATHS = new Set([
   // We always report changes to these bundles, even if the change is
   // insignificant or non-existent.
-  'oss-stable/react-dom/cjs/react-dom.production.min.js',
-  'oss-experimental/react-dom/cjs/react-dom.production.min.js',
+  'oss-stable/react-dom/cjs/react-dom.production.js',
+  'oss-experimental/react-dom/cjs/react-dom.production.js',
   'facebook-www/ReactDOM-prod.classic.js',
   'facebook-www/ReactDOM-prod.modern.js',
 ]);

package.json

@@ -94,7 +94,6 @@
     "shelljs": "^0.8.5",
     "signedsource": "^2.0.0",
     "targz": "^1.0.1",
-    "terser": "^5.30.3",
     "through2": "^3.0.1",
     "tmp": "^0.1.0",
     "typescript": "^3.7.5",