Skip to content

Commit cecba01

Browse files
zhongwuzwkelset
authored andcommittedJun 19, 2019
Removed autoresizing mask for modal host container view (#25150)
Summary: Fixes #18177 . Related #24497. Autoresizing mask would conflict with `AutoLayout`. For example , it would impact `SafeAreaView`. And actually we don't need to use autoresizing mask, we observe the bounds change notification and [update the frame manually](https://github.com/facebook/react-native/blob/1151c096dab17e5d9a6ac05b61aacecd4305f3db/React/Views/RCTModalHostView.m#L59). ## Changelog [iOS] [Fixed] - Removed autoresizing mask for modal host container view Pull Request resolved: #25150 Differential Revision: D15645148 Pulled By: cpojer fbshipit-source-id: 95d5f40feaa980b959a3de6e273dccac8158c57b
1 parent 06fffc2 commit cecba01

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed
 

‎React/Views/RCTModalHostView.m

-2
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,6 @@ - (void)insertReactSubview:(UIView *)subview atIndex:(NSInteger)atIndex
129129
[subview addGestureRecognizer:_menuButtonGestureRecognizer];
130130
}
131131
#endif
132-
subview.autoresizingMask = UIViewAutoresizingFlexibleHeight |
133-
UIViewAutoresizingFlexibleWidth;
134132

135133
[_modalViewController.view insertSubview:subview atIndex:0];
136134
_reactSubview = subview;

0 commit comments

Comments
 (0)
Please sign in to comment.