Skip to content

Commit b133bf6

Browse files
retyuifacebook-github-bot
authored andcommittedJan 30, 2024·
fix: [TS] Update translateX & translateY types to support % (#42671)
Summary: After update to the latest `react-native` version we discover that we are unable to use `number%` value for `translate*` props : ```tsx StyleSheet.create({ root: { transform: [ { translateX: '-50%' }, // ^^^^^^ TS Error: Type string is not assignable to type AnimatableNumericValue | undefined ], } }); ``` --- percentage values are supported, demo: https://snack.expo.dev/retyui/test-tstransform ## Changelog: [GENERAL] [FIXED] - Update typescript definition of `translateX` & `translateX` to be able to use percentage values Pull Request resolved: #42671 Test Plan: `yarn tsc --noEmit` Reviewed By: rozele, cortinico Differential Revision: D53146046 Pulled By: NickGerleman fbshipit-source-id: 3486e7a9b55b98c36cc96b2bca4bb27841061e80
1 parent e97ba47 commit b133bf6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed
 

‎packages/react-native/Libraries/StyleSheet/StyleSheetTypes.d.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -155,11 +155,11 @@ interface ScaleYTransform {
155155
}
156156

157157
interface TranslateXTransform {
158-
translateX: AnimatableNumericValue;
158+
translateX: AnimatableNumericValue | `${number}%`;
159159
}
160160

161161
interface TranslateYTransform {
162-
translateY: AnimatableNumericValue;
162+
translateY: AnimatableNumericValue | `${number}%`;
163163
}
164164

165165
interface SkewXTransform {

0 commit comments

Comments
 (0)
Please sign in to comment.