Skip to content

Commit 5e51e54

Browse files
committedApr 29, 2020
Update react.gradle (#28776)
Summary: Running `./gradlew assembleRelease` fails as the path to the CLI contains a new line at the end. We don't run this command in `debug` mode, hence it passed the testing. My bad. Fixed, checked in both `debug` with `bundleInDebug: true` and `release`. Fixes #28700 ## Changelog [INTERNAL] [ANDROID] - Fix `React.gradle` to build Android apps in production Pull Request resolved: #28776 Test Plan: Running `./gradlew assembleRelease` works Reviewed By: hramos Differential Revision: D21287789 Pulled By: TheSavior fbshipit-source-id: dc3ec8eef7a919b072b562d2bd455e2f704bc083
1 parent b645f23 commit 5e51e54

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎react.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def detectCliPath(config) {
2929
return config.cliPath
3030
}
3131

32-
def cliPath = ["node", "-e", "console.log(require('react-native/cli').bin);"].execute([], projectDir).text
32+
def cliPath = ["node", "-e", "console.log(require('react-native/cli').bin);"].execute([], projectDir).text.trim()
3333

3434
if (cliPath) {
3535
return cliPath

0 commit comments

Comments
 (0)
Please sign in to comment.