Skip to content

Commit 25c5d1c

Browse files
mdvaccafacebook-github-bot
authored andcommittedJan 31, 2024·
Mark classes of package animated as @nullsafe (#42727)
Summary: Pull Request resolved: #42727 All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D53200096 fbshipit-source-id: 2d965ebcb568e7bbff4b37db11070c5079fa6394
1 parent 6cae417 commit 25c5d1c

File tree

6 files changed

+17
-5
lines changed

6 files changed

+17
-5
lines changed
 

‎packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/AnimatedNode.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,13 @@
99

1010
import androidx.annotation.Nullable;
1111
import com.facebook.infer.annotation.Assertions;
12+
import com.facebook.infer.annotation.Nullsafe;
1213
import java.util.ArrayList;
1314
import java.util.List;
1415

1516
/** Base class for all Animated.js library node types that can be created on the "native" side. */
16-
/*package*/ abstract class AnimatedNode {
17+
/*package*/ @Nullsafe(Nullsafe.Mode.LOCAL)
18+
abstract class AnimatedNode {
1719

1820
public static final int INITIAL_BFS_COLOR = 0;
1921

‎packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/DecayAnimation.java

+2
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,14 @@
77

88
package com.facebook.react.animated;
99

10+
import com.facebook.infer.annotation.Nullsafe;
1011
import com.facebook.react.bridge.ReadableMap;
1112

1213
/**
1314
* Implementation of {@link AnimationDriver} providing support for decay animations. The
1415
* implementation is copied from the JS version in {@code AnimatedImplementation.js}.
1516
*/
17+
@Nullsafe(Nullsafe.Mode.LOCAL)
1618
class DecayAnimation extends AnimationDriver {
1719

1820
private final double mVelocity;

‎packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/DiffClampAnimatedNode.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,12 @@
77

88
package com.facebook.react.animated;
99

10+
import com.facebook.infer.annotation.Nullsafe;
1011
import com.facebook.react.bridge.JSApplicationCausedNativeException;
1112
import com.facebook.react.bridge.ReadableMap;
1213

13-
/*package*/ class DiffClampAnimatedNode extends ValueAnimatedNode {
14+
/*package*/ @Nullsafe(Nullsafe.Mode.LOCAL)
15+
class DiffClampAnimatedNode extends ValueAnimatedNode {
1416
private final NativeAnimatedNodesManager mNativeAnimatedNodesManager;
1517
private final int mInputNodeTag;
1618
private final double mMin;

‎packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/ModulusAnimatedNode.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,12 @@
77

88
package com.facebook.react.animated;
99

10+
import com.facebook.infer.annotation.Nullsafe;
1011
import com.facebook.react.bridge.JSApplicationCausedNativeException;
1112
import com.facebook.react.bridge.ReadableMap;
1213

13-
/*package*/ class ModulusAnimatedNode extends ValueAnimatedNode {
14+
/*package*/ @Nullsafe(Nullsafe.Mode.LOCAL)
15+
class ModulusAnimatedNode extends ValueAnimatedNode {
1416

1517
private final NativeAnimatedNodesManager mNativeAnimatedNodesManager;
1618
private final int mInputNode;

‎packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/ObjectAnimatedNode.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
package com.facebook.react.animated;
99

1010
import androidx.annotation.Nullable;
11+
import com.facebook.infer.annotation.Nullsafe;
1112
import com.facebook.react.bridge.JavaOnlyArray;
1213
import com.facebook.react.bridge.JavaOnlyMap;
1314
import com.facebook.react.bridge.ReadableArray;
@@ -19,7 +20,8 @@
1920
* Native counterpart of object animated node (see AnimatedObject class in
2021
* AnimatedImplementation.js)
2122
*/
22-
/* package */ class ObjectAnimatedNode extends AnimatedNode {
23+
/* package */ @Nullsafe(Nullsafe.Mode.LOCAL)
24+
class ObjectAnimatedNode extends AnimatedNode {
2325

2426
private static final String VALUE_KEY = "value";
2527
private static final String NODE_TAG_KEY = "nodeTag";

‎packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/SpringAnimation.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,16 @@
77

88
package com.facebook.react.animated;
99

10+
import com.facebook.infer.annotation.Nullsafe;
1011
import com.facebook.react.bridge.ReadableMap;
1112

1213
/**
1314
* Implementation of {@link AnimationDriver} providing support for spring animations. The
1415
* implementation has been copied from android implementation of Rebound library (see <a
1516
* href="http://facebook.github.io/rebound/">http://facebook.github.io/rebound/</a>)
1617
*/
17-
/*package*/ class SpringAnimation extends AnimationDriver {
18+
/*package*/ @Nullsafe(Nullsafe.Mode.LOCAL)
19+
class SpringAnimation extends AnimationDriver {
1820

1921
// maximum amount of time to simulate per physics iteration in seconds (4 frames at 60 FPS)
2022
private static final double MAX_DELTA_TIME_SEC = 0.064;

0 commit comments

Comments
 (0)
Please sign in to comment.