Skip to content

Commit ccab1fc

Browse files
BridgeARfkling
authored andcommittedMar 7, 2018
Fix error handling for http (#242)
The reject handler were always called no matter if there was an error or not.
1 parent a85f52b commit ccab1fc

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed
 

‎src/Runner.js

+8-6
Original file line numberDiff line numberDiff line change
@@ -157,17 +157,19 @@ function run(transformFile, paths, options) {
157157
})
158158
.on('end', () => {
159159
temp.open('jscodeshift', (err, info) => {
160-
reject(err);
161-
fs.write(info.fd, contents);
162-
fs.close(info.fd, function(err) {
163-
reject(err);
164-
transform(info.path).then(resolve, reject);
160+
if (err) return reject(err);
161+
fs.write(info.fd, contents, function (err) {
162+
if (err) return reject(err);
163+
fs.close(info.fd, function(err) {
164+
if (err) return reject(err);
165+
transform(info.path).then(resolve, reject);
166+
});
165167
});
166168
});
167169
})
168170
})
169171
.on('error', (e) => {
170-
reject(e.message);
172+
reject(e);
171173
});
172174
});
173175
} else if (!fs.existsSync(transformFile)) {

0 commit comments

Comments
 (0)
Please sign in to comment.