fix(theme): codeblock buttons should be kept on the right when using RTL locale

[Vishruta-Patil]

Pre-flight checklist

• I have read the Contributing Guidelines on pull requests.
• If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
• If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

The codeblock on RTL locale puts copy button on the left while code is also on the left. Therefore added one more class in docusaurus-theme-classic package to solve this issue. Now the code is on left and copy button is on the right side.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

#8792

[facebook-github-bot]

Hi @Vishruta-Patil!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[netlify]

✅ [V2]

Built without sensitive environment variables

Name	Link
🔨 Latest commit	90d9c36
🔍 Latest deploy log	https://app.netlify.com/sites/docusaurus-2/deploys/641b4b19ba01bc0008cb116d
😎 Deploy Preview	https://deploy-preview-8803--docusaurus-2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[github-actions]

⚡️ Lighthouse report for the deploy preview of this PR

URL	Performance	Accessibility	Best Practices	SEO	PWA	Report
/	🟢 94	🟢 97	🟢 100	🟢 100	🟢 90	Report
/docs/installation	🟠 77	🟢 100	🟢 100	🟢 100	🟢 90	Report

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[slorber]

Legit bug but wrong solution, that does not work in practice

I would have normally edited your PR with the correct solution, but your PR settings do not allow me to submit changes to your contribution so you'll have to fix it yourself 🤪

[slorber]

This extra class is not needed

[slorber]

That's not a good fix because our RTLCSS postCSS plugin will automatically transform right to left.

If you test your dev locally yarn start:website --locale fa you'll notice it doesn't work.

The solution is to add an rtl ignore directive to avoid this auto transform to happen:

.buttonGroup {
  display: flex;
  column-gap: 0.2rem;
  position: absolute;
  /* rtl:ignore */
  right: calc(var(--ifm-pre-padding) / 2);
  top: calc(var(--ifm-pre-padding) / 2);
}

See directives syntax: https://rtlcss.com/learn/usage-guide/control-directives/index.html

[slorber]

Oh apparently I'm able to push to your branch finally, just a little locale issue because your branch is named "main"

fix #8792

[Vishruta-Patil]

@slorber Do I have to make the suggested changes ?
But after making those changes, the button is still on the left side (on the local)

[slorber]

It's good thanks 👍

It works for me, but requires rebuilding the project or having yarn watch running in another terminal