@@ -106,47 +106,47 @@ describe('favicon()', function () {
106
106
} )
107
107
108
108
describe ( 'requests' , function ( ) {
109
- var server
110
109
before ( function ( ) {
111
- server = createServer ( )
110
+ this . server = createServer ( )
112
111
} )
113
112
114
113
it ( 'should serve icon' , function ( done ) {
115
- request ( server )
114
+ request ( this . server )
116
115
. get ( '/favicon.ico' )
117
116
. expect ( 'Content-Type' , 'image/x-icon' )
118
117
. expect ( 200 , done )
119
118
} )
120
119
121
120
it ( 'should include cache-control' , function ( done ) {
122
- request ( server )
121
+ request ( this . server )
123
122
. get ( '/favicon.ico' )
124
123
. expect ( 'Cache-Control' , / p u b l i c / )
125
124
. expect ( 200 , done )
126
125
} )
127
126
128
127
it ( 'should include strong etag' , function ( done ) {
129
- request ( server )
128
+ request ( this . server )
130
129
. get ( '/favicon.ico' )
131
130
. expect ( 'ETag' , / ^ " [ ^ " ] + " $ / )
132
131
. expect ( 200 , done )
133
132
} )
134
133
135
134
it ( 'should deny POST' , function ( done ) {
136
- request ( server )
135
+ request ( this . server )
137
136
. post ( '/favicon.ico' )
138
137
. expect ( 'Allow' , 'GET, HEAD, OPTIONS' )
139
138
. expect ( 405 , done )
140
139
} )
141
140
142
141
it ( 'should understand OPTIONS' , function ( done ) {
143
- request ( server )
142
+ request ( this . server )
144
143
. options ( '/favicon.ico' )
145
144
. expect ( 'Allow' , 'GET, HEAD, OPTIONS' )
146
145
. expect ( 200 , done )
147
146
} )
148
147
149
148
it ( 'should 304 when If-None-Match matches' , function ( done ) {
149
+ var server = this . server
150
150
request ( server )
151
151
. get ( '/favicon.ico' )
152
152
. expect ( 200 , function ( err , res ) {
@@ -159,6 +159,7 @@ describe('favicon()', function () {
159
159
} )
160
160
161
161
it ( 'should 304 when If-None-Match matches weakly' , function ( done ) {
162
+ var server = this . server
162
163
request ( server )
163
164
. get ( '/favicon.ico' )
164
165
. expect ( 200 , function ( err , res ) {
@@ -171,13 +172,13 @@ describe('favicon()', function () {
171
172
} )
172
173
173
174
it ( 'should ignore non-favicon requests' , function ( done ) {
174
- request ( server )
175
+ request ( this . server )
175
176
. get ( '/' )
176
177
. expect ( 404 , 'oops' , done )
177
178
} )
178
179
179
180
it ( 'should work with query string' , function ( done ) {
180
- request ( server )
181
+ request ( this . server )
181
182
. get ( '/favicon.ico?v=1' )
182
183
. expect ( 'Content-Type' , 'image/x-icon' )
183
184
. expect ( 200 , done )
0 commit comments